Bugzilla – Attachment 178139 Details for
Bug 38986
Restore "Any" option to purchase suggestion filter by fund
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38986: Restore Any in fund dropdown on suggestions homepage
Bug-38986-Restore-Any-in-fund-dropdown-on-suggesti.patch (text/plain), 2.85 KB, created by
Marcel de Rooy
on 2025-02-17 13:55:22 UTC
(
hide
)
Description:
Bug 38986: Restore Any in fund dropdown on suggestions homepage
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-02-17 13:55:22 UTC
Size:
2.85 KB
patch
obsolete
>From 34807dba7adc7573ff66bbc67a67145059964752 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry <andrew@bywatersolutions.com> >Date: Mon, 3 Feb 2025 18:13:26 +0000 >Subject: [PATCH] Bug 38986: Restore Any in fund dropdown on suggestions > homepage >Content-Type: text/plain; charset=utf-8 > >This patch restores Any as a budget filter option on the suggestions homepage, but does not allow one to select Any when saving a suggestion > >To test: >1 - have two suggestions, one with a fund assigned and one without >2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option >3 - apply patch, reload page >4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly >5 - confirm you cannot select Any when creating a new suggestion > >Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> > >Bug 38986: Restore Any option to suggestions homepage filter > >"Any" should show all suggestions, any fund value and null fund values. One should not be able to create a suggeestion set to "Any" >"None" should show only suggestions with no fund value selected. A new suggestion should default to "None" > >To Test: >1: have two suggestions, one with a fund selected and one without >2: go to suggestions homepage, confirm the filter does not have an "Any" option >3: apply patch, reload page >4: confirm the fund filter on suggestion homepage now has both Any and None and they behave as described above >5: confirm the fund filter defaults to Any as you change the branch filter >6: create a new suggestion, confirm its fund defaults to None and cannot be set to Any > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > .../prog/en/modules/suggestion/suggestion.tt | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index dbf76898de..1b0931861c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -1335,14 +1335,13 @@ > [% BLOCK funds_dropdown %] > <label for="budgetid">Fund:</label> > <select name="budgetid" id="budgetid"> >- [% IF op == 'save' %] >+ [% UNLESS op == 'save' %] > <option value="">Any</option> >+ [% END %] >+ [% IF budgetid == '__NONE__' %] >+ <option value="__NONE__" selected="selected">None</option> > [% ELSE %] >- [% IF budgetid == '__NONE__' %] >- <option value="__NONE__" selected="selected">None</option> >- [% ELSE %] >- <option value="__NONE__">None</option> >- [% END %] >+ <option value="__NONE__">None</option> > [% END %] > [% FOREACH budget IN sugg_budgets %] > [% IF ( budget.selected ) %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38986
:
177282
|
177285
|
177473
|
177474
|
177494
|
178101
| 178139