Bugzilla – Attachment 17818 Details for
Bug 8419
Suspended holds appear on the daily holds queue
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 8419 - Suspended holds appear on the daily holds queue
PASSED-QA-Bug-8419---Suspended-holds-appear-on-the.patch (text/plain), 1.74 KB, created by
Katrin Fischer
on 2013-04-29 19:59:38 UTC
(
hide
)
Description:
[PASSED QA] Bug 8419 - Suspended holds appear on the daily holds queue
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-04-29 19:59:38 UTC
Size:
1.74 KB
patch
obsolete
>From 9b25760798f8a287005723616caabae84c5dc049 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 15 Apr 2013 08:39:26 -0400 >Subject: [PATCH] [PASSED QA] Bug 8419 - Suspended holds appear on the daily > holds queue > >This bug was reintroduced by the patch for bu 5911: Transport Cost Matrix > >Test Plan: >1) Place a hold on a record >2) Run build_holds_queue.pl >3) Verify the hold is showing in the holds queue >4) Suspend the hold >5) Re-run build_holds_queue.pl >6) Note the hold is still in the holds queue >7) Apply patch >8) Re-run build_holds_queue.pl >9) Note the hold is no longer in the holds queue > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Passes test plan and QA script. >--- > C4/HoldsQueue.pm | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm >index 655269b..dc43113 100755 >--- a/C4/HoldsQueue.pm >+++ b/C4/HoldsQueue.pm >@@ -222,7 +222,9 @@ sub GetBibsWithPendingHoldRequests { > FROM reserves > WHERE found IS NULL > AND priority > 0 >- AND reservedate <= CURRENT_DATE()"; >+ AND reservedate <= CURRENT_DATE() >+ AND suspend = 0 >+ "; > my $sth = $dbh->prepare($bib_query); > > $sth->execute(); >@@ -265,6 +267,7 @@ sub GetPendingHoldRequestsForBib { > AND found IS NULL > AND priority > 0 > AND reservedate <= CURRENT_DATE() >+ AND suspend = 0 > ORDER BY priority"; > my $sth = $dbh->prepare($request_query); > $sth->execute($biblionumber); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8419
:
10771
|
11383
|
17451
|
17782
| 17818