Bugzilla – Attachment 178297 Details for
Bug 35434
Non-superlibrarians should not place holds in other libraries when IndependentBranches is enabled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35434: (follow-up) Added canreservefromotherbranches
Bug-35434-follow-up-Added-canreservefromotherbranc.patch (text/plain), 1.43 KB, created by
Hammat wele
on 2025-02-18 17:51:02 UTC
(
hide
)
Description:
Bug 35434: (follow-up) Added canreservefromotherbranches
Filename:
MIME Type:
Creator:
Hammat wele
Created:
2025-02-18 17:51:02 UTC
Size:
1.43 KB
patch
obsolete
>From 10211f840185de527e8b1ea1d9eab61feba426d1 Mon Sep 17 00:00:00 2001 >From: Hammat Wele <hammat.wele@inlibro.com> >Date: Wed, 31 Jul 2024 21:28:41 +0000 >Subject: [PATCH] Bug 35434: (follow-up) Added canreservefromotherbranches > >When IndependentBranches is enabled, canreservefromotherbranches >set to don't allow is also required to prevent non-superlibrarians >from placing holds in other libraries. > >Signed-off-by: David Nind <david@davidnind.com> >--- > Koha/Item.pm | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > >diff --git a/Koha/Item.pm b/Koha/Item.pm >index 60144f96d0..2713e73dad 100644 >--- a/Koha/Item.pm >+++ b/Koha/Item.pm >@@ -1032,7 +1032,15 @@ is not passed. > sub pickup_locations { > my ( $self, $params ) = @_; > >- return Koha::Libraries->search( { branchcode => $self->holdingbranch } ) if C4::Context->preference("IndependentBranches") && !C4::Context->IsSuperLibrarian(); >+ if ( C4::Context->preference("IndependentBranches") >+ and !C4::Context->preference("canreservefromotherbranches") ) >+ { >+ my $userenv = C4::Context->userenv; >+ unless ( C4::Context->IsSuperLibrarian ) { >+ return Koha::Libraries->new()->empty if ( $self->homebranch ne $userenv->{branch} ); >+ return Koha::Libraries->search( { branchcode => $self->homebranch } ); >+ } >+ } > > Koha::Exceptions::MissingParameter->throw( parameter => 'patron' ) > unless exists $params->{patron}; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35434
:
159346
|
161509
|
166648
|
169917
|
169918
|
169919
|
176045
|
176046
|
176047
|
178296
| 178297 |
178298