Bugzilla – Attachment 178317 Details for
Bug 38375
SIP2 syspref SIP2SortBinMapping is not working
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38375: Splitting SIP2SortBinMapping syspref does not support all operating systems' line endings
Bug-38375-Splitting-SIP2SortBinMapping-syspref-doe.patch (text/plain), 986 bytes, created by
Martin Renvoize (ashimema)
on 2025-02-19 11:05:24 UTC
(
hide
)
Description:
Bug 38375: Splitting SIP2SortBinMapping syspref does not support all operating systems' line endings
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-02-19 11:05:24 UTC
Size:
986 bytes
patch
obsolete
>From 7eab40524b94b0fbd64d6fffeeb60818e76e0228 Mon Sep 17 00:00:00 2001 >From: Lari Strand <lari.strand@koha-suomi.fi> >Date: Tue, 21 Jan 2025 10:22:51 +0200 >Subject: [PATCH] Bug 38375: Splitting SIP2SortBinMapping syspref does not > support all operating systems' line endings > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/SIP/ILS/Transaction/Checkin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm >index 4c7d84a6d94..ad02ad78970 100644 >--- a/C4/SIP/ILS/Transaction/Checkin.pm >+++ b/C4/SIP/ILS/Transaction/Checkin.pm >@@ -262,7 +262,7 @@ sub _get_sort_bin { > # Get the mapping and split on newlines > my $raw_map = C4::Context->preference('SIP2SortBinMapping'); > return unless $raw_map; >- @lines = split /\r\n/, $raw_map; >+ @lines = split /[\r\n]+/, $raw_map; > } > > # Iterate over the mapping. The first hit wins. >-- >2.48.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38375
:
176853
| 178317 |
178318
|
178319