Bugzilla – Attachment 178350 Details for
Bug 20551
Add option for including deleted records in export_records.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20551: Refactor unmotivated partially applied validator function
Bug-20551-Refactor-unmotivated-partially-applied-v.patch (text/plain), 2.83 KB, created by
Arthur Suzuki
on 2025-02-19 15:00:11 UTC
(
hide
)
Description:
Bug 20551: Refactor unmotivated partially applied validator function
Filename:
MIME Type:
Creator:
Arthur Suzuki
Created:
2025-02-19 15:00:11 UTC
Size:
2.83 KB
patch
obsolete
>From 57e5c1ab820a3d18197543e851ec6819969199b9 Mon Sep 17 00:00:00 2001 >From: David Gustafsson <david.gustafsson@ub.gu.se> >Date: Mon, 4 Apr 2022 15:25:02 +0200 >Subject: [PATCH] Bug 20551: Refactor unmotivated partially applied validator > function > >--- > Koha/Exporter/Record.pm | 31 +++++++++++++------------------ > 1 file changed, 13 insertions(+), 18 deletions(-) > >diff --git a/Koha/Exporter/Record.pm b/Koha/Exporter/Record.pm >index b143da4b0ca..ed2c6cd730c 100644 >--- a/Koha/Exporter/Record.pm >+++ b/Koha/Exporter/Record.pm >@@ -249,29 +249,24 @@ sub export { > } > if ( $format eq 'iso2709' ) { > my $encoding_validator = sub { >- my ($record_type) = @_; >- return sub { >- my ($record) = @_; >- my $errorcount_on_decode = >- eval { scalar( MARC::File::USMARC->decode( $record->as_usmarc )->warnings() ) }; >- if ( $errorcount_on_decode || $@ ) { >- my ( $id_tag, $id_subfield ) = GetMarcFromKohaField( 'biblio.biblionumber', '' ); >- my $record_id = $record->subfield( $id_tag, $id_subfield ); >- my $msg = "$record_type $record_id could not be USMARC decoded/encoded. " . ( $@ // '' ); >- chomp $msg; >- Koha::Logger->get->warn($msg); >- return 0; >- } >- return 1; >+ my ( $record, $record_type ) = @_; >+ my $errorcount_on_decode = >+ eval { scalar( MARC::File::USMARC->decode( $record->as_usmarc )->warnings() ) }; >+ if ( $errorcount_on_decode || $@ ) { >+ my ( $id_tag, $id_subfield ) = GetMarcFromKohaField( 'biblio.biblionumber', '' ); >+ my $record_id = $record->subfield( $id_tag, $id_subfield ); >+ my $msg = "$record_type $record_id could not be USMARC decoded/encoded. " . ( $@ // '' ); >+ chomp $msg; >+ Koha::Logger->get->warn($msg); >+ return 0; > } >+ return 1; > }; >- my $validator = $encoding_validator->('Record'); >- for my $record ( grep { $validator->($_) } @records ) { >+ for my $record ( grep { $encoding_validator->( $_, 'Record' ) } @records ) { > print $record->as_usmarc(); > } > if (@deleted_records) { >- $validator = $encoding_validator->('Deleted record'); >- for my $deleted_record ( grep { $validator->($_) } @deleted_records ) { >+ for my $deleted_record ( grep { $encoding_validator->( $_, 'Deleted record' ) } @deleted_records ) { > print $deleted_record->as_usmarc(); > } > } >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20551
:
73916
|
73923
|
75113
|
82843
|
82914
|
82918
|
90184
|
90190
|
90220
|
93619
|
93620
|
93621
|
105403
|
116408
|
116409
|
116410
|
116411
|
123099
|
123101
|
123102
|
125211
|
125212
|
125213
|
125214
|
125215
|
125216
|
128895
|
128896
|
128897
|
128898
|
128899
|
128900
|
132936
|
132937
|
176623
|
176624
|
176625
|
176626
|
176627
|
176628
|
176629
|
176630
|
176631
|
177536
|
178343
|
178344
|
178345
|
178346
|
178347
|
178348
|
178349
|
178350
|
178351
|
178352
|
178353
|
178378
|
178379
|
178575
|
178617
|
178618
|
178619
|
178679
|
178680
|
178681
|
178682
|
179748
|
179749
|
180648
|
180649
|
180650
|
180651
|
180652
|
180653
|
180654
|
180655
|
180656
|
180657
|
180658
|
180659
|
180660
|
180661
|
180662
|
180663
|
180664
|
180665