Bugzilla – Attachment 17842 Details for
Bug 10157
koha-email-enable error handling
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10157 - koha-email-enable error handling
Bug-10157---koha-email-enable-error-handling.patch (text/plain), 3.30 KB, created by
Tomás Cohen Arazi (tcohen)
on 2013-04-30 13:09:05 UTC
(
hide
)
Description:
Bug 10157 - koha-email-enable error handling
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2013-04-30 13:09:05 UTC
Size:
3.30 KB
patch
obsolete
>From 9e6486d1ee1295cf1526644f5d95bdc8b00cf7b3 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Tue, 30 Apr 2013 10:05:44 -0300 >Subject: [PATCH] Bug 10157 - koha-email-enable error handling >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >koha-email-enable now >- Checks the instance exists. >- Checks if email is already enabled. > >Regards >To+ > >Sponsored-by: Universidad Nacional de Córdoba >--- > debian/docs/koha-email-enable.xml | 4 +- > debian/scripts/koha-email-enable | 81 +++++++++++++++++++++++++++++++------ > 2 files changed, 71 insertions(+), 14 deletions(-) > >diff --git a/debian/docs/koha-email-enable.xml b/debian/docs/koha-email-enable.xml >index 0f39010..1aeb2f1 100644 >--- a/debian/docs/koha-email-enable.xml >+++ b/debian/docs/koha-email-enable.xml >@@ -17,7 +17,7 @@ > > <refnamediv> > <refname>koha-email-enable</refname> >- <refpurpose>Turn on the email for a Koha instance.</refpurpose> >+ <refpurpose>Turn on the email for Koha instances.</refpurpose> > <refclass>UNIX/Linux</refclass> > </refnamediv> > >@@ -28,7 +28,7 @@ > </refsynopsisdiv> > > <refsect1><title>Description</title> >- <para>Turn on the email for a Koha instance.</para> >+ <para>Turn on the email for Koha instances.</para> > </refsect1> > > <refsect1><title>See also</title> >diff --git a/debian/scripts/koha-email-enable b/debian/scripts/koha-email-enable >index da63589..a130c49 100755 >--- a/debian/scripts/koha-email-enable >+++ b/debian/scripts/koha-email-enable >@@ -1,6 +1,6 @@ > #!/bin/sh > # >-# koha-email-enable -- turn on the email for a Koha instance >+# koha-email-enable - turn on the email for Koha instances > # Copyright 2010 Catalyst IT, Ltd > # > # This program is free software: you can redistribute it and/or modify >@@ -18,19 +18,76 @@ > > set -e > >-if [ "$#" = 0 ] >-then >- echo "Enables email for a koha instance." 1>&2 >- echo "Usage: $0 instancename..." 1>&2 >+die() >+{ >+ echo "$@" 1>&2 > exit 1 >-fi >-libdir=/var/lib/koha >+} >+ >+warn() >+{ >+ echo "$@" 1>&2 >+} >+ >+is_instance() >+{ >+ local instancename=$1 >+ >+ if find /etc/koha/sites -mindepth 1 -maxdepth 1 \ >+ -type d -printf '%f\n'\ >+ | grep -q -x $instancename ; then >+ return 0 >+ else >+ return 1 >+ fi >+} >+ >+is_email_enabled() >+{ >+ local instancename=$1 >+ >+ if [ -e /var/lib/koha/$instancename/email.enabled ]; then >+ return 0 >+ else >+ return 1 >+ fi >+} >+ >+enable_email() >+{ >+ local instancename=$1 >+ local libdir="/var/lib/koha" >+ >+ touch $libdir/$instancename/email.enabled >+ >+ echo "Enabled email for instance $instancename." >+} >+ >+usage() >+{ >+ local scriptname=$0 >+ cat <<EOF >+Enables the email for Koha instances. >+ >+Usage: $scriptname instancename1 instancename2... >+ >+EOF >+} >+ >+# Parse command line. >+[ $# -ge 1 ] || ( usage ; die "Missing instance name..." ) >+ > for name in "$@" > do >- if [ ! -d $libdir/$name ] >- then >- echo "$0: no koha instance \"$name\"" 1>&2 >- continue >+ if is_instance $name; then >+ if ! is_email_enabled $name; then >+ enable_email $name >+ else >+ warn "Email already enabled for instance $name." >+ fi >+ else >+ warn "Unknown instance $name." > fi >- touch $libdir/$name/email.enabled > done >+ >+exit 0 >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10157
:
17842
|
18106