Bugzilla – Attachment 178442 Details for
Bug 39170
Remote code execution within task scheduler
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39170: Improve validation of report ID
Bug-39170-Improve-validation-of-report-ID.patch (text/plain), 1.13 KB, created by
Phil Ringnalda
on 2025-02-20 23:56:37 UTC
(
hide
)
Description:
Bug 39170: Improve validation of report ID
Filename:
MIME Type:
Creator:
Phil Ringnalda
Created:
2025-02-20 23:56:37 UTC
Size:
1.13 KB
patch
obsolete
>From e55b160f608f2c334da00cae553ee2d2c044eb2f Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Thu, 20 Feb 2025 00:04:39 +0000 >Subject: [PATCH] Bug 39170: Improve validation of report ID > >This change improves the validation of the report ID passed by the user. > >Test plan: >0. Apply the patch >1. koha-plack --restart kohadev >2. Create a SQL report >3. Go to /cgi-bin/koha/tools/scheduler.pl >4. Add in a Time, Date, and Email >5. Choose your report from the list >6. Click "Save" >7. Note that your report is saved > >Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> >--- > tools/scheduler.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/scheduler.pl b/tools/scheduler.pl >index 3a7b03915d..37d5a06883 100755 >--- a/tools/scheduler.pl >+++ b/tools/scheduler.pl >@@ -60,7 +60,7 @@ if ( $op eq 'cud-add' ) { > my $starttime = $input->param('starttime'); > $starttime =~ s/\://g; > my $start = $startdate . $starttime; >- my $report = $input->param('report'); >+ my $report = int( $input->param('report') ); > if ($report) { > my $saved_report; > my $report_id = int($report); >-- >2.47.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39170
:
178382
|
178383
|
178442
|
178444