Bugzilla – Attachment 178864 Details for
Bug 32630
Don't delete ILL requests when patron is deleted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32630: Update get_notice
Bug-32630-Update-getnotice.patch (text/plain), 1.83 KB, created by
Pedro Amorim
on 2025-02-28 15:53:12 UTC
(
hide
)
Description:
Bug 32630: Update get_notice
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-02-28 15:53:12 UTC
Size:
1.83 KB
patch
obsolete
>From 3c127c2caddd937d17e16c66c3b7cb9b4f9c14e4 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Thu, 20 Feb 2025 11:40:22 +0000 >Subject: [PATCH] Bug 32630: Update get_notice > >Make it consider the possibility of a patron not existing. >This ensures that placing a request with partners does not error and works as expected even if the ILL request's borrowernumber is undef > >To test: >1) Run the test file before and after applying this patch: >prove t/db_dependent/Koha/ILL/Requests.t > >To test (ILL request is kept after borrower is deleted): >1) Apply all patches except this one >2) Enable ILLModule and create an ILL request. >3) Add a type, valid cardnumber and library. >4) Delete the associated borrower. >5) Confirm the ILL request is still listed and shown as expected > >Continue test, confirm follow-up bug is fixed: >6) Click 'Place request with partners' >7) You get a ERR_TOO_MANY_REDIRECTS error >8) Apply this patch and restart plack. Repeat. >9) Confirm the place request with partners libraries page is shown correctly > >Sponsored-by: UKHSA - UK Health Security Agency >Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> >--- > Koha/ILL/Request.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/ILL/Request.pm b/Koha/ILL/Request.pm >index 90035032e42..c57400cb03f 100644 >--- a/Koha/ILL/Request.pm >+++ b/Koha/ILL/Request.pm >@@ -1905,7 +1905,7 @@ sub get_notice { > letter_code => $params->{notice_code}, > branchcode => $self->branchcode, > message_transport_type => $params->{transport}, >- lang => $self->patron->lang, >+ lang => $self->patron ? $self->patron->lang : undef, > tables => { > illrequests => $self->illrequest_id, > borrowers => $self->borrowernumber, >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32630
:
178387
|
178388
|
178389
|
178390
|
178391
|
178392
|
178393
|
178858
|
178859
|
178860
|
178861
|
178862
|
178863
|
178864
|
178876
|
178877
|
178878
|
178879
|
178880
|
178881
|
178882
|
178883