Bugzilla – Attachment 178870 Details for
Bug 39217
Self checkout: Fix ugly error on wrong password when logging in
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39217: Fix ugly error on wrong password in SCO login
Bug-39217-Fix-ugly-error-on-wrong-password-in-SCO-.patch (text/plain), 3.70 KB, created by
Owen Leonard
on 2025-02-28 18:52:34 UTC
(
hide
)
Description:
Bug 39217: Fix ugly error on wrong password in SCO login
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-02-28 18:52:34 UTC
Size:
3.70 KB
patch
obsolete
>From e7ca304ff705a29b21546415674054140307449f Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 28 Feb 2025 18:18:24 +0000 >Subject: [PATCH] Bug 39217: Fix ugly error on wrong password in SCO login > >This patch updates the self checkout page so that it uses the same >message as the regular OPAC in response to a user trying to log in with >incorrect credentials. > >To test, apply the patch enable the self checkout module if necessary. > >- Set the SelfCheckoutByLogin system preference to "cardnumber" >- Test the process of logging in as a patron to self checkout: > Submitting an invalid library card number should trigger an error. >- Set the SelfCheckoutByLogin system preference to "username and > password." >- Test this login form by submitting a valid card number or username and > an invalid password. You should see the same error message. >- NOTE: If you submit an invalid card number or username you will get no > message at all, which is a bug in and of itself. > >QA note: I think the qa tool warning is an error in the tidy check. > >Sponsored-by: Athens County Public Libraries >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 9 ++++++--- > 2 files changed, 7 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >index 5414b9e6ef..6dfe88d4be 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >@@ -77,7 +77,7 @@ > <div class="alert alert-info"> > <p > >You entered an incorrect username or password. Please try again! But note that passwords are case >- sensitive[% IF Koha.Preference('FailedLoginAttempts') %]and that your account will be locked out after a fixed number of failed login attempts[% END %]. Please contact a library staff member if you >+ sensitive[% IF Koha.Preference('FailedLoginAttempts') %] and that your account will be locked after a fixed number of failed login attempts[% END %]. Please contact a library staff member if you > continue to have problems.</p > > > </div> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >index 15f863e122..55122a58b3 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >@@ -296,9 +296,12 @@ > [% PROCESS display_errors %] > > [% IF patronid && nouser %] >- <div class="alert alert-warning"> >- <h3>Sorry</h3> >- <p>The userid <strong>[% patronid | html %]</strong> was not found in the database. Please try again.</p> >+ <div class="alert alert-info"> >+ <p >+ >You entered an incorrect username or password. Please try again! But note that passwords are case >+ sensitive[% IF Koha.Preference('FailedLoginAttempts') %] and that your account will be locked after a fixed number of failed login attempts[% END %]. Please contact a library staff member if you >+ continue to have problems.</p >+ > > </div> > [% END %] > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39217
:
178870
|
179419
|
179564
|
179683
|
181032
|
181033