Bugzilla – Attachment 178883 Details for
Bug 32630
Don't delete ILL requests when patron is deleted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32630: Add tests
Bug-32630-Add-tests.patch (text/plain), 1.82 KB, created by
Lisette Scheer
on 2025-02-28 21:26:50 UTC
(
hide
)
Description:
Bug 32630: Add tests
Filename:
MIME Type:
Creator:
Lisette Scheer
Created:
2025-02-28 21:26:50 UTC
Size:
1.82 KB
patch
obsolete
>From ff297226e7b892b53c8c0a264737b2a55ac76be8 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Thu, 20 Feb 2025 11:38:28 +0000 >Subject: [PATCH] Bug 32630: Add tests > >prove t/db_dependent/Koha/ILL/Requests.t > >Sponsored-by: UKHSA - UK Health Security Agency >Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> >Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> >--- > t/db_dependent/Koha/ILL/Requests.t | 25 ++++++++++++++++++++++++- > 1 file changed, 24 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/ILL/Requests.t b/t/db_dependent/Koha/ILL/Requests.t >index c5ba6262cbc..d647679c2ee 100755 >--- a/t/db_dependent/Koha/ILL/Requests.t >+++ b/t/db_dependent/Koha/ILL/Requests.t >@@ -1065,7 +1065,7 @@ subtest 'Backend core methods' => sub { > > subtest 'Helpers' => sub { > >- plan tests => 25; >+ plan tests => 26; > > $schema->storage->txn_begin; > >@@ -1341,6 +1341,29 @@ Attribute: Pages=[% illrequestattributes.pages %] > 'appending to a note works' > ); > >+ my $illrq_without_patron = $builder->build( >+ { >+ source => 'Illrequest', >+ value => { branchcode => "HDE", borrowernumber => undef } >+ } >+ ); >+ my $illrq_obj_without_patron = Koha::ILL::Requests->find( $illrq_without_patron->{illrequest_id} ); >+ $illrq_obj_without_patron->_config($config); >+ $illrq_obj_without_patron->_backend($backend); >+ >+ my $get_notice_without_patron = $illrq_obj_without_patron->get_notice( >+ { >+ notice_code => 'ILL_REQUEST_CANCEL', >+ transport => 'email' >+ } >+ ); >+ >+ is( >+ $get_notice_without_patron->{lang}, >+ "default", >+ 'Koha::ILL::Request->get_notice lang correctly defaults to "default" for a request without a patron' >+ ); >+ > $schema->storage->txn_rollback; > }; > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32630
:
178387
|
178388
|
178389
|
178390
|
178391
|
178392
|
178393
|
178858
|
178859
|
178860
|
178861
|
178862
|
178863
|
178864
|
178876
|
178877
|
178878
|
178879
|
178880
|
178881
|
178882
| 178883