Bugzilla – Attachment 178913 Details for
Bug 35560
Use the REST API for holds history
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35560: (follow-up) Changes to classes and ids; BS5 follow-ups
Bug-35560-follow-up-Changes-to-classes-and-ids-BS5.patch (text/plain), 4.79 KB, created by
Owen Leonard
on 2025-03-04 12:43:50 UTC
(
hide
)
Description:
Bug 35560: (follow-up) Changes to classes and ids; BS5 follow-ups
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-03-04 12:43:50 UTC
Size:
4.79 KB
patch
obsolete
>From d39acb3cbeddc5dd04b6902ff7ca404ca440e07d Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 4 Mar 2025 12:38:42 +0000 >Subject: [PATCH] Bug 35560: (follow-up) Changes to classes and ids; BS5 > follow-ups > >This follow-up changes the "selected" class to "select_hold_status" to >avoid possible future collisions with other CSS. IDs are added to the >checkbox containers because I can already tell that some libraries will >want to hide the "Processing" checkbox which is only relevant to some >setups. > >The patch also makes a couple corrections to "alerts" to update them >with BS5 classes. >--- > .../prog/en/modules/members/holdshistory.tt | 20 +++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt >index b2d9a525ee8..8f39e5e7859 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt >@@ -59,23 +59,23 @@ > [% IF patron.holds.count %] > <div id="current_holds_filters" data-table-id="table_holdshistory"> > <p> >- <span class="selected"> >+ <span class="select_hold_status" id="status_show_all"> > <input id="current_show_all" type="checkbox" checked="checked" class="show_all" /> > <label for="current_show_all">Show all</label> > </span> >- <span class="selected"> >+ <span class="select_hold_status" id="status_show_pending"> > <input id="current_pending_filter" type="checkbox" checked="checked" /> > <label for="current_pending_filter">Pending</label> > </span> >- <span class="selected"> >+ <span class="select_hold_status" id="status_show_waiting"> > <input id="current_waiting_filter" type="checkbox" checked="checked" /> > <label for="current_waiting_filter">Waiting</label> > </span> >- <span class="selected"> >+ <span class="select_hold_status" id="status_show_processing"> > <input id="current_processing_filter" type="checkbox" checked="checked" /> > <label for="current_processing_filter">Processing</label> > </span> >- <span class="selected"> >+ <span class="select_hold_status" id="status_show_intransit"> > <input id="current_transit_filter" type="checkbox" checked="checked" /> > <label for="current_transit_filter">In transit</label> > </span> >@@ -101,7 +101,7 @@ > </thead> > </table> > [% ELSE %] >- <div class="dialog message">This patron has no current holds.</div> >+ <div class="alert alert-info">This patron has no current holds.</div> > [% END %] > > <h2 id="past_holds_heading">Past holds</h2> >@@ -111,15 +111,15 @@ > [% IF patron.old_holds.count %] > <div id="old_holds_filters" data-table-id="table_oldholdshistory"> > <p> >- <span class="selected"> >+ <span class="select_hold_status" id="status_show_all_old"> > <input id="old_show_all" type="checkbox" checked="checked" class="show_all" /> > <label for="old_show_all">Show all</label> > </span> >- <span class="selected"> >+ <span class="select_hold_status" id="status_show_fulfilled"> > <input id="old_fulfilled_filter" type="checkbox" checked="checked" /> > <label for="old_fulfilled_filter">Fulfilled</label> > </span> >- <span class="selected"> >+ <span class="select_hold_status" id="status_show_cancelled"> > <input id="old_cancelled_filter" type="checkbox" checked="checked" /> > <label for="old_cancelled_filter">Cancelled</label> > </span> >@@ -145,7 +145,7 @@ > </thead> > </table> > [% ELSE %] >- <div class="dialog message">This patron has no historical holds.</div> >+ <div class="alert alert-info">This patron has no historical holds.</div> > [% END %] > </div> > [% END %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35560
:
160100
|
160101
|
163831
|
163832
|
164093
|
165231
|
165232
|
165233
|
177161
|
177162
|
177163
|
177200
|
177201
|
177202
|
177203
|
177792
|
177793
|
177794
|
178897
|
178898
|
178899
|
178910
|
178911
|
178912
|
178913
|
179552
|
179573
|
179574
|
179575
|
179576
|
179577