Bugzilla – Attachment 178934 Details for
Bug 28530
Allow configuration of floating limits by item type
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28530: (QA follow-up) correct item count and limit enforcement
Bug-28530-QA-follow-up-correct-item-count-and-limi.patch (text/plain), 1.39 KB, created by
Andrew Fuerste-Henry
on 2025-03-04 20:50:45 UTC
(
hide
)
Description:
Bug 28530: (QA follow-up) correct item count and limit enforcement
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2025-03-04 20:50:45 UTC
Size:
1.39 KB
patch
obsolete
>From 5abf7731d8e81654149b349acea6e41d6f6fcba7 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry <andrew@bywatersolutions.com> >Date: Tue, 4 Mar 2025 20:47:13 +0000 >Subject: [PATCH] Bug 28530: (QA follow-up) correct item count and limit > enforcement > >Corrected the count of items to limit to the current branch. Also set the limit to trigger when the count of items at the branch is currently at the limit before the item to be checked in. >--- > C4/Circulation.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 49f625430d..90a1f4800a 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2250,8 +2250,8 @@ sub AddReturn { > my $effective_itemtype = $item->effective_itemtype; > my $limit = Koha::Library::FloatLimits->find( { itemtype => $effective_itemtype, branchcode => $branch } ); > if ($limit) { >- my $count = Koha::Items->count( { itype => $limit->itemtype } ); >- if ( $count > $limit->float_limit ) { >+ my $count = Koha::Items->count( { itype => $limit->itemtype, holdingbranch => $branch } ); >+ if ( $count >= $limit->float_limit ) { > my $transfer_branchcode = Koha::Library::FloatLimits->lowest_ratio_library( $item, $branch ); > if ( $transfer_branchcode ne $branch ) { > $returnbranch = $transfer_branchcode; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28530
:
160038
|
160039
|
160040
|
160041
|
160042
|
160043
|
160044
|
160045
|
160046
|
160047
|
160048
|
160049
|
160050
|
160053
|
160054
|
160055
|
160056
|
160057
|
160058
|
160061
|
160062
|
160063
|
160064
|
160065
|
160066
|
160067
|
160068
|
160071
|
160072
|
160073
|
160074
|
160075
|
160076
|
160077
|
160078
|
160079
|
160080
|
160081
|
160082
|
160083
|
160084
|
163919
|
168343
|
168344
|
168345
|
168346
|
168347
|
168348
|
168349
|
168350
|
178762
|
178763
|
178764
|
178765
|
178766
|
178767
|
178768
|
178769
|
178783
|
178784
|
178785
|
178934
|
178935
|
178936
|
178937
|
178938
|
178939
|
178940
|
178941
|
178942
|
178943
|
178944
|
178945
|
178946
|
179943
|
179944
|
179945
|
179946
|
179947
|
179948
|
179949
|
179950
|
179951
|
179952
|
179953
|
179954
|
179955
|
180028
|
182931