Bugzilla – Attachment 179003 Details for
Bug 39258
Remove extra delete button in report preview modal
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39258: Delete extra delete button in report preview
Bug-39258-Delete-extra-delete-button-in-report-pre.patch (text/plain), 2.41 KB, created by
Andrew Fuerste-Henry
on 2025-03-05 21:01:47 UTC
(
hide
)
Description:
Bug 39258: Delete extra delete button in report preview
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2025-03-05 21:01:47 UTC
Size:
2.41 KB
patch
obsolete
>From 61a83598e9f5b58add576090fbcf68b63b333404 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry <andrew@bywatersolutions.com> >Date: Wed, 5 Mar 2025 20:59:19 +0000 >Subject: [PATCH] Bug 39258: Delete extra delete button in report preview > >To test: >1 - save a report >2 - click Preview SQL for that report from the Saved Reports page >3 - see there are two delete buttons >4 - apply patch, reload page >5 - now there is one delete button >6 - confirm that delete button gives a confirmation message and then deletes the report >--- > .../prog/en/modules/reports/guided_reports_start.tt | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 55afc39ff0..41eda2e003 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -2608,7 +2608,6 @@ > <a id="preview-modal-duplicate" class="btn btn-default" href="/cgi-bin/koha/reports/guided_reports.pl?op=duplicate&id=' + reportid + '"><i class="fa fa-copy" aria-hidden="true"></i> ' + _("Duplicate") + '</a>\ > <a id="preview-modal-duplicate" class="btn btn-default" href="/cgi-bin/koha/tools/scheduler.pl?id=' + reportid + '"><i class="fa-solid fa-clock" aria-hidden="true"></i> ' + _("Schedule") + '</a>\ > <a class="btn btn-default submit-form-link" href="#" data-id="' + reportid + '" data-action="guided_reports.pl" data-method="post" data-op="cud-delete" data-confirmation-msg="' + _("Are you sure you want to delete this report?") + '"><i class="fa fa-trash-can" aria-hidden="true"></i> Delete</a>\ >- <a id="preview-modal-delete"href="#" class="btn btn-default" title="Delete this saved report"><i class="fa fa-trash-can aria-hidden="true""></i> ' + _("Delete") + '</a>\ > <a id="preview-modal-runreport" class="btn btn-default" href="/cgi-bin/koha/reports/guided_reports.pl?id=' + reportid + '&op=run"><i class="fa fa-play" aria-hidden="true"></i> ' + _("Run report") + '</a>\ > <a href="#" id="preview-sql-modal-cancel" data-bs-dismiss="modal" class="btn btn-default"><i class="fa fa-times" aria-hidden="true"></i> ' + _("Close") + '</a>\ > </div>\ >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39258
:
179003
|
179006
|
179499
|
179565
|
179901
|
180530