Bugzilla – Attachment 179050 Details for
Bug 29410
Dates compared arithmetically in MsgType.pm (warns: Argument isn't numeric in numeric ne)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29410: Resolve warn on numeric ne for two dates
Bug-29410-Resolve-warn-on-numeric-ne-for-two-dates.patch (text/plain), 1.31 KB, created by
Paul Derscheid
on 2025-03-07 10:03:29 UTC
(
hide
)
Description:
Bug 29410: Resolve warn on numeric ne for two dates
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2025-03-07 10:03:29 UTC
Size:
1.31 KB
patch
obsolete
>From 707e2d561ac02fa284ff0e4e9194fe1ec50c81c4 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 4 Mar 2025 14:46:12 +0000 >Subject: [PATCH] Bug 29410: Resolve warn on numeric ne for two dates > >Simply, remove the !=0 test. Test for true. > >Test plan: >Restart SIP. >Ask item info (SIP 17) on a waiting hold. It must have a >hold pickup date. >Check that warn disappears with this patch. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > C4/SIP/Sip/MsgType.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm >index 23e0682372..3ae395d3bd 100644 >--- a/C4/SIP/Sip/MsgType.pm >+++ b/C4/SIP/Sip/MsgType.pm >@@ -1352,10 +1352,10 @@ sub handle_item_information { > : timestamp( $item->due_date ); > $resp .= add_field( FID_DUE_DATE, $due_date, $server ); > } >- if ( ( $i = $item->recall_date ) != 0 ) { >+ if ( $i = $item->recall_date ) { > $resp .= add_field( FID_RECALL_DATE, timestamp($i), $server ); > } >- if ( ( $i = $item->hold_pickup_date ) != 0 ) { >+ if ( $i = $item->hold_pickup_date ) { > $resp .= add_field( FID_HOLD_PICKUP_DATE, timestamp($i), $server ); > } > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29410
:
178920
| 179050