Bugzilla – Attachment 179073 Details for
Bug 39154
About: add a warning for obsoleted sip.log
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39154: Add sip.log test in about
Bug-39154-Add-siplog-test-in-about.patch (text/plain), 2.27 KB, created by
Martin Renvoize (ashimema)
on 2025-03-07 12:31:07 UTC
(
hide
)
Description:
Bug 39154: Add sip.log test in about
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-03-07 12:31:07 UTC
Size:
2.27 KB
patch
obsolete
>From 10abdb3148eaa81eebc8b0ee6ac5d708215b84a1 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 18 Feb 2025 14:30:56 +0000 >Subject: [PATCH] Bug 39154: Add sip.log test in about > >See bug 36954. The file sip.log should not be found anymore in >log4perl.conf. > >Test plan: >Edit log4perl.conf. Replace sip-output.log by sip.log. >Check About, tab sysinfo. You should see a warn. >Edit again. Switch back to sip-output.log. >Verify that there is no warn anymore on about. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > about.pl | 4 +++- > koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 ++ > 2 files changed, 5 insertions(+), 1 deletion(-) > >diff --git a/about.pl b/about.pl >index 799f8ed9107..93532d1b0f8 100755 >--- a/about.pl >+++ b/about.pl >@@ -826,7 +826,9 @@ sub log4perl_check { > for my $line (@lines) { > next unless $line =~ m|log4perl\.appender\.\w+\.filename=(.*)|; > my $file = $1; >- if ( !-w $file ) { >+ if ( $file =~ /sip\.log$/ ) { >+ push @log4perl_errors, 'sip_log_still_found'; >+ } elsif ( !-w $file ) { > push @log4perl_errors, 'logfile_not_writable'; > > #NOTE: An unwritable logfile blocks plack.psgi. So you won't reach this script. (BZ 39155) >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >index 71b5a911537..904b37f372e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >@@ -449,6 +449,8 @@ > <span>One of the logfiles listed in the config file is not writable.</span> > [% CASE 'cannot_init_module' %] > <span>The Koha::Logger module cannot be initiated correctly (check the log file).</span> >+ [% CASE 'sip_log_still_found' %] >+ <span>Config file log4perl.conf still refers to sip.log (instead of sip-output.log).</span> > [% CASE %] > <span>Unknown error '[% e | html %]'.</span> > [% END %] >-- >2.48.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39154
:
178275
|
178293
| 179073