Bugzilla – Attachment 179092 Details for
Bug 28453
Update pagination subroutine to generate Bootstrap markup
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28453: Adjust OPAC pagination
Bug-28453-Adjust-OPAC-pagination.patch (text/plain), 3.25 KB, created by
Jonathan Druart
on 2025-03-10 08:53:04 UTC
(
hide
)
Description:
Bug 28453: Adjust OPAC pagination
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-03-10 08:53:04 UTC
Size:
3.25 KB
patch
obsolete
>From fea9f74d4af04c3a60b74ca329272ddcd3d47293 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 10 Mar 2025 09:51:28 +0100 >Subject: [PATCH] Bug 28453: Adjust OPAC pagination > >--- > .../bootstrap/en/modules/opac-authoritiessearchresultlist.tt | 4 ++-- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- > t/db_dependent/selenium/regressions.t | 3 ++- > 3 files changed, 5 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt >index f48eedfb15a..8075aaa4236 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt >@@ -46,7 +46,7 @@ > <h1>Authority search results</h1> > > [% IF total %] >- <div class="pages">[% pagination_bar | $raw %]</div> >+ <div class="pages" id="pagination_top"> [% pagination_bar | $raw %] </div> > [% END %] > <div id="results"> > [% IF ( total ) %] >@@ -103,7 +103,7 @@ > </div> > <!-- / .searchresults --> > >- <div class="pages">[% pagination_bar | $raw %]</div> >+ <div class="pages" id="pagination_bottom"> [% pagination_bar | $raw %] </div> > [% END # / IF total %] > </div> > <!-- / #userauthsearchresults --> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >index af6c9d1cfdf..22dcb2a5453 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >@@ -830,7 +830,7 @@ > </tbody> > </table> > <!-- /.table --> >- <div class="pages">[% pagination_bar | $raw %]</div> >+ <div class="pages" id="pagination_bottom"> [% pagination_bar | $raw %] </div> > [% ELSE %] > [% IF public %] > <p>No public lists.</p> >diff --git a/t/db_dependent/selenium/regressions.t b/t/db_dependent/selenium/regressions.t >index 4b47effe869..a55d9b2876b 100755 >--- a/t/db_dependent/selenium/regressions.t >+++ b/t/db_dependent/selenium/regressions.t >@@ -293,7 +293,8 @@ subtest 'XSS vulnerabilities in pagination' => sub { > $s->add_error_handler; > is( $alert_text, undef, 'No alert box displayed, even if evil intent' ); > >- my $second_page = $driver->find_element('//div[@class="pages"]/span[@class="currentPage"]/following-sibling::a'); >+ my $second_page = >+ $driver->find_element('//div[@class="pages"]/ul/li[@class="page-item active"]/following-sibling::li/a'); > like( > $second_page->get_attribute('href'), qr{(?|&)public=1(&|$)}, > 'The second page should display category without the invalid value' >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28453
:
125849
|
126836
|
126837
|
126845
|
126846
|
127210
|
171076
|
171077
|
171078
|
171150
|
175272
|
175273
|
175274
|
175279
|
175280
|
175281
|
176663
|
176664
|
176665
|
176666
|
176667
|
177846
|
177847
|
177848
| 179092