Bugzilla – Attachment 179099 Details for
Bug 39268
When switching tabs between 'My lists' and 'Public lists' incorrect lists can be displayed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39268: Fix tab switching on lists page
Bug-39268-Fix-tab-switching-on-lists-page.patch (text/plain), 2.02 KB, created by
Martin Renvoize (ashimema)
on 2025-03-10 12:04:31 UTC
(
hide
)
Description:
Bug 39268: Fix tab switching on lists page
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-03-10 12:04:31 UTC
Size:
2.02 KB
patch
obsolete
>From 885b7bf5dec21c246c91cc196e54b9d23ff88bb1 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 6 Mar 2025 20:34:25 +0000 >Subject: [PATCH] Bug 39268: Fix tab switching on lists page > >This patch fixes broken tab switching on the staff interface lists page. >It was broken by the upgrade to Bootstrap 5. > >To test, apply the patch and go to the Lists page in the staff >interface. > >- If necessary, create multiple public and private lists. >- Confirm that switching between the "Your lists" tab and the "Public > lists" tab works correctly. >- Try using URL parameters to load each tab: > http://127.0.0.1:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=0 > http://127.0.0.1:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=1 > >Sponsored-by: Athens County Public Libraries >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >index c7bb4d5f5d6..52069f4ed12 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >@@ -712,15 +712,13 @@ > $('a[href="#publicshelves_tab_panel"]').tab("show"); > } > >- $('a[data-bs-toggle="tab"]').on("click", function(e){ >+ $('#tabs a[data-bs-toggle="tab"]').on('shown.bs.tab', function (e) { > let target = $(this).attr("href"); > if( target == "#publicshelves_tab_panel" ){ > public = 1; > } else { > public = 0; > } >- }) >- .on('shown.bs.tab', function (e) { > dtListResults.DataTable().draw(); > }); > >-- >2.48.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39268
:
179020
|
179022
| 179099