Bugzilla – Attachment 179158 Details for
Bug 39301
pseudonymize_statistics.pl script generates too many background jobs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39301: pseudonymize_statistics.pl script generates too many background jobs
Bug-39301-pseudonymizestatisticspl-script-generate.patch (text/plain), 2.60 KB, created by
Nick Clemens (kidclamp)
on 2025-03-11 11:24:38 UTC
(
hide
)
Description:
Bug 39301: pseudonymize_statistics.pl script generates too many background jobs
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2025-03-11 11:24:38 UTC
Size:
2.60 KB
patch
obsolete
>From 4318f3a009af5037fafcea8c6a1030b1a5607485 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 11 Mar 2025 11:08:26 +0000 >Subject: [PATCH] Bug 39301: pseudonymize_statistics.pl script generates too > many background jobs > >This patch changes the script to use 'Koha::PseudonymizedTransaction->new_from_statistic' directly >rather than calling 'Koha::Statistic->pseudonymize()' which generates a background job. > >Additionally, some of the checks from 'pseudonymnize' and the background job are moved into the search >so we don't fetch any to pseudonymize that should not be. > >To test: > 1 - Generate some entries in statistics (checkin, checkout, renew, etc) > 2 - Enable pseudonymization (see bug 28911 if you need bcrypt settings) > 3 - perl misc/maintenance/pseudonymize_statistics.pl -v -c > 4 - Statistics pseudonymized > 5 - Check the background jobs table, note jobs were generated > 6 - Apply patch > 7 - perl misc/maintenance/pseudonymize_statistics.pl -v -c > 8 - You get same count as before, and are warned of existing pseudonymized transactions > 9 - enter 'Y' to continue >10 - Check the pseudonymized_transacations table >11 - Confirm same rows were generated twice >12 - Check the background jobs >13 - Confirm there were no new jobs generated (for pseudonymization) >--- > misc/maintenance/pseudonymize_statistics.pl | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > >diff --git a/misc/maintenance/pseudonymize_statistics.pl b/misc/maintenance/pseudonymize_statistics.pl >index 51930b422b0..105b37b9926 100755 >--- a/misc/maintenance/pseudonymize_statistics.pl >+++ b/misc/maintenance/pseudonymize_statistics.pl >@@ -45,7 +45,13 @@ unless ( C4::Context->preference('Pseudonymization') ) { > $before //= format_sqldatetime( dt_from_string(), 'sql', undef, 1 ); > print "Searching for statistics before $before\n" if $verbose; > >-my $statistics = Koha::Statistics->search( { datetime => { '<=' => $before } } ); >+my $statistics = Koha::Statistics->search( >+ { >+ datetime => { '<=' => $before }, >+ type => { '-in' => \@Koha::Statistic::pseudonymization_types }, >+ borrowernumber => { '!=' => undef } >+ } >+); > print $statistics->count() . " statistics found\n" if $verbose; > > my $existing_pseudo_stats = Koha::PseudonymizedTransactions->search( { datetime => { '<=' => $before } } )->count; >@@ -66,7 +72,7 @@ if ( !$confirm ) { > } > > while ( my $statistic = $statistics->next ) { >- $statistic->pseudonymize(); >+ Koha::PseudonymizedTransaction->new_from_statistic($statistic)->store(); > } > > print $statistics->count() . " statistics pseudonymized\n" if $verbose; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39301
:
179158
|
179177