Bugzilla – Attachment 179252 Details for
Bug 39190
Rework new (S)FTP classes to be polymorphic classes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39190: Add $result to Koha::Objects `object_class` calls
Bug-39190-Add-result-to-KohaObjects-objectclass-ca.patch (text/plain), 2.31 KB, created by
Martin Renvoize (ashimema)
on 2025-03-13 14:35:58 UTC
(
hide
)
Description:
Bug 39190: Add $result to Koha::Objects `object_class` calls
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-03-13 14:35:58 UTC
Size:
2.31 KB
patch
obsolete
>From e21bae7e95f2f3523c979e55f49da44e6e518e68 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 24 Jan 2025 11:26:51 +0000 >Subject: [PATCH] Bug 39190: Add $result to Koha::Objects `object_class` calls > >This allows us to do dynamic polymorphic classing on calls to 'find', >'find_or_create', 'single', 'next', 'last' and 'as_list' etc. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Objects.pm | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/Koha/Objects.pm b/Koha/Objects.pm >index 405e6a76679..21b16d020bf 100644 >--- a/Koha/Objects.pm >+++ b/Koha/Objects.pm >@@ -94,7 +94,7 @@ sub find { > unless ( !@pars || none { defined($_) } @pars ) { > my $result = $self->_resultset()->find(@pars); > if ($result) { >- $object = $self->object_class()->_new_from_dbic($result); >+ $object = $self->object_class($result)->_new_from_dbic($result); > } > } > >@@ -114,7 +114,7 @@ sub find_or_create { > > return unless $result; > >- my $object = $self->object_class->_new_from_dbic($result); >+ my $object = $self->object_class($result)->_new_from_dbic($result); > > return $object; > } >@@ -301,7 +301,7 @@ sub single { > my $single = $self->_resultset()->single; > return unless $single; > >- return $self->object_class()->_new_from_dbic($single); >+ return $self->object_class($single)->_new_from_dbic($single); > } > > =head3 Koha::Objects->next(); >@@ -319,7 +319,7 @@ sub next { > my $result = $self->_resultset()->next(); > return unless $result; > >- my $object = $self->object_class()->_new_from_dbic($result); >+ my $object = $self->object_class($result)->_new_from_dbic($result); > > return $object; > } >@@ -341,7 +341,7 @@ sub last { > > my ($result) = $self->_resultset->slice( $count - 1, $count - 1 ); > >- my $object = $self->object_class()->_new_from_dbic($result); >+ my $object = $self->object_class($result)->_new_from_dbic($result); > > return $object; > } >@@ -507,7 +507,7 @@ wraps the DBIC object in a corresponding Koha object > sub _wrap { > my ( $self, @dbic_rows ) = @_; > >- my @objects = map { $self->object_class->_new_from_dbic($_) } @dbic_rows; >+ my @objects = map { $self->object_class($_)->_new_from_dbic($_) } @dbic_rows; > > return @objects; > } >-- >2.48.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39190
:
178555
|
178556
|
178557
|
178558
|
178559
|
178560
|
178561
|
178562
|
178563
|
178564
|
178565
|
178566
|
178567
|
178568
|
178569
|
178570
|
178571
|
179252
|
179253
|
179254
|
179255
|
179256
|
179257
|
179258
|
179259
|
179260
|
179261
|
179262
|
179263
|
179264
|
179265
|
179266
|
179267
|
179268
|
179396
|
179397
|
179398
|
179399
|
179400
|
179401
|
179402
|
179403
|
179404
|
179405
|
179406
|
179407
|
179408
|
179409
|
179410
|
179411
|
179412
|
179413
|
179589
|
179590
|
179591
|
179592
|
179593
|
179594
|
179595
|
179596
|
179597
|
179598
|
179599
|
179600
|
179601
|
179602
|
179603
|
179604
|
179605
|
179606
|
179646
|
179647
|
179648
|
179649
|
179650
|
179651
|
179652
|
179653
|
179654
|
179655
|
179656
|
179657
|
179658
|
179659
|
179660
|
179661
|
179662
|
179663
|
179992
|
179993
|
179994
|
179995
|
179996
|
179997
|
179998
|
179999
|
180000
|
180001
|
180002
|
180003
|
180004
|
180005
|
180006
|
180010
|
180011
|
180012
|
180013
|
180014
|
180015
|
180016
|
180017
|
180018
|
180019
|
180020
|
180021
|
180022
|
180023
|
180024
|
180025