Bugzilla – Attachment 179313 Details for
Bug 37784
Patron password hash can be fetched using report dictionary
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37784: (QA follow-up) Bail out to new definition
Bug-37784-QA-follow-up-Bail-out-to-new-definition.patch (text/plain), 2.02 KB, created by
Marcel de Rooy
on 2025-03-14 09:50:17 UTC
(
hide
)
Description:
Bug 37784: (QA follow-up) Bail out to new definition
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-03-14 09:50:17 UTC
Size:
2.02 KB
patch
obsolete
>From e1578fa53e172ad0fd52c9bf443587aa71e17183 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 14 Mar 2025 09:31:57 +0000 >Subject: [PATCH] Bug 37784: (QA follow-up) Bail out to new definition >Content-Type: text/plain; charset=utf-8 > >The code went back to step 3 but the error message is not there. >It is easier to go back to the start: no need to fetch columns. >And this is now an exception; it will only come up when trying >malicious things. > >Also turned foreach and unless forbidden around. No need to go >into the loop when we found a forbidden field. > >Test plan: >See first patch. You should see the message now. >--- > reports/dictionary.pl | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) > >diff --git a/reports/dictionary.pl b/reports/dictionary.pl >index 86bbf1e5fd..8803482774 100755 >--- a/reports/dictionary.pl >+++ b/reports/dictionary.pl >@@ -81,8 +81,8 @@ if ( $op eq 'add_form' ) { > my $columnstring = join( ',', @columns ); > my $forbidden = Koha::Report->new->check_columns( undef, \@columns ); > my @column_loop; >- foreach my $column (@columns) { >- unless ($forbidden) { >+ unless ($forbidden) { >+ foreach my $column (@columns) { > my %tmp_hash; > $tmp_hash{'name'} = $column; > my $type = get_column_type($column); >@@ -112,16 +112,7 @@ if ( $op eq 'add_form' ) { > 'columnstring' => $columnstring, > ); > } else { >- my $columns = get_columns( $area, $input ); >- $template->param( >- 'step_3' => 1, >- 'area' => $area, >- 'definition_name' => $definition_name, >- 'definition_description' => $definition_description, >- 'columns' => \@column_loop, >- 'columnstring' => $columnstring, >- 'passworderr' => 1, >- ); >+ $template->param( 'new_dictionary' => 1, passworderr => 1 ); > } > > } elsif ( $op eq 'cud-add_form_5' ) { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37784
:
170898
|
171041
|
174817
|
177824
|
179297
|
179312
| 179313 |
179314
|
179567
|
179568
|
179569