Bugzilla – Attachment 17937 Details for
Bug 8278
Replace YUI autocomplete in UNIMARC 210c plugin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-Off] Bug 8278: build the structure with to_json instead of manually.
Bug-8278-build-the-structure-with-tojson-instead-o.patch (text/plain), 1.19 KB, created by
Kyle M Hall (khall)
on 2013-05-03 17:05:48 UTC
(
hide
)
Description:
[Signed-Off] Bug 8278: build the structure with to_json instead of manually.
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-05-03 17:05:48 UTC
Size:
1.19 KB
patch
obsolete
>From 6bdecf8bf8204335c69366397e99f390f65052d6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 22 Apr 2013 16:19:01 +0200 >Subject: [PATCH] Bug 8278: build the structure with to_json instead of manually. > >Test plan: >Same as previously. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > cataloguing/ysearch.pl | 12 ++++-------- > 1 files changed, 4 insertions(+), 8 deletions(-) > >diff --git a/cataloguing/ysearch.pl b/cataloguing/ysearch.pl >index 9c69939..49dfa39 100755 >--- a/cataloguing/ysearch.pl >+++ b/cataloguing/ysearch.pl >@@ -29,6 +29,7 @@ use CGI; > use C4::Context; > use C4::Charset; > use C4::Auth qw/check_cookie_auth/; >+use JSON qw/ to_json /; > > my $input = new CGI; > my $query = $input->param('term'); >@@ -54,14 +55,9 @@ $sql .= qq( ORDER BY $field); > my $sth = $dbh->prepare($sql); > $sth->execute("$query%", "% $query%", "%-$query%"); > >-print "["; >-my $i = 0; >+my $a = []; > while ( my $rec = $sth->fetchrow_hashref ) { >- if($i > 0){ print ","; } >- print "{\"fieldvalue\":\"" . nsb_clean($rec->{$field}) . "\"" . >- "}"; >- $i++; >+ push @$a, { fieldvalue => nsb_clean($rec->{$field}) }; > } >-print "]"; >- > >+print to_json($a); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8278
:
15997
|
16441
|
17110
|
17189
|
17475
|
17480
|
17597
|
17937
|
18002
|
18003
|
18004
|
18005