Attachment 17939 Details for Bug 10185 – Bug 10185: Fix update 3.09.00.025

[patch] Bug 10185: Fix update 3.09.00.025

Bug-10185-Fix-update-30900025.patch (text/plain), 1.38 KB, created by Kyle M Hall (khall) on 2013-05-03 17:18:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2013-05-03 17:18:53 UTC

Size: 1.38 KB

patch

obsolete

>From c90ff09049b1cc0b0295b77b33bec80f3b429c50 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 May 2013 17:20:17 +0200
>Subject: [PATCH] Bug 10185: Fix update 3.09.00.025
>
>It can remove all reserves from reserves table when there is no entries
>in old_reserves.
>This is due to @ai which is set to NULL in
>  SET @ai = ( SELECT MAX( reserve_id ) FROM tmp_reserves )
>and reserve_id > NULL returns no results in
>  INSERT INTO reserves SELECT * FROM tmp_reserves WHERE reserve_id > @ai
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> installer/data/mysql/updatedatabase.pl |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index be4dfa2..64f0fde 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -5516,7 +5516,7 @@ if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) {
>     ");
>     $dbh->do('TRUNCATE reserves');
>     $dbh->do('ALTER TABLE reserves ADD reserve_id INT( 11 ) NOT NULL AUTO_INCREMENT PRIMARY KEY FIRST');
>-    $dbh->do('INSERT INTO reserves SELECT * FROM tmp_reserves WHERE reserve_id > @ai');
>+    $dbh->do('INSERT INTO reserves SELECT * FROM tmp_reserves WHERE reserve_id > COALESCE(@ai, 0)');
>     $dbh->do('DROP TABLE tmp_reserves');
>     $dbh->do('COMMIT');
> 
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 10185: 17934 | 17939 | 17958 | 17973 | 17974 | 17975