Bugzilla – Attachment 179431 Details for
Bug 38981
Local cover images failing to load in OPAC search results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38981: Local cover images failing to load in OPAC search results
Bug-38981-Local-cover-images-failing-to-load-in-OP.patch (text/plain), 1.75 KB, created by
David Nind
on 2025-03-18 10:25:06 UTC
(
hide
)
Description:
Bug 38981: Local cover images failing to load in OPAC search results
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-03-18 10:25:06 UTC
Size:
1.75 KB
patch
obsolete
>From 23414864118d946ab4e494bc409ac28e501969bd Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 11 Mar 2025 15:07:27 +0000 >Subject: [PATCH] Bug 38981: Local cover images failing to load in OPAC search > results > >This patch uncomments some code which was incorrectly left commented >after debugging. > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index 6447d0b3f0..2cfd946085 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -598,9 +598,9 @@ > > $(coverSlide).find(".cover-image").eq(0).show(); > >- // if( $(coverSlide).find(".cover-image").length < 1 ){ >- // $(coverSlide).remove(); >- // } else { >+ if( $(coverSlide).find(".cover-image").length < 1 ){ >+ $(coverSlide).remove(); >+ } else { > // This is a suboptimal workaround; we should do this via load, but > // the image code is scattered all over now. We come here now after > // window load and wait_for_images (so load completed). >@@ -609,7 +609,7 @@ > if( !this.complete || this.naturalHeight == 0 ) check_complete = 0; > }); > if( check_complete ) $(coverSlide).removeClass('cover-slides'); >- // } >+ } > }); > > $(".cover-slider").on("click",".cover-nav", function(e){ >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38981
:
179170
|
179210
|
179431
|
179432
|
179560
|
179561