Bugzilla – Attachment 179453 Details for
Bug 39367
Add POD to all subroutines/methods
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39367: Manual changes
Bug-39367-Manual-changes.patch (text/plain), 42.53 KB, created by
Jonathan Druart
on 2025-03-18 13:35:18 UTC
(
hide
)
Description:
Bug 39367: Manual changes
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-03-18 13:35:18 UTC
Size:
42.53 KB
patch
obsolete
>From a04cc705363a091533912fde1be8344d087f9dfe Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 18 Mar 2025 14:07:04 +0100 >Subject: [PATCH] Bug 39367: Manual changes > >--- > C4/Acquisition.pm | 36 +- > C4/Auth.pm | 55 ++- > C4/Auth_with_shibboleth.pm | 10 +- > C4/Barcodes.pm | 163 +++---- > C4/Barcodes/hbyymmincr.pm | 4 + > C4/Creators/PDF.pm | 4 + > C4/Creators/Template.pm | 10 +- > C4/External/BakerTaylor.pm | 40 +- > C4/Installer/PerlModules.pm | 10 +- > C4/Labels/Label.pm | 10 +- > C4/Linker/Default.pm | 4 + > C4/Linker/FirstMatch.pm | 4 + > C4/Linker/LastMatch.pm | 4 + > C4/Output.pm | 10 +- > C4/Patroncards/Lib.pm | 40 +- > C4/SIP/ILS.pm | 4 + > C4/SIP/ILS/Transaction/Checkin.pm | 4 + > C4/Scrubber.pm | 13 +- > C4/Search/History.pm | 10 +- > Koha/Edifact/Line.pm | 514 +++++++++-------------- > Koha/Edifact/Message.pm | 126 +++--- > Koha/Edifact/Transport.pm | 30 +- > Koha/Patron/Files.pm | 2 +- > Koha/Template/Plugin/AuthorisedValues.pm | 20 +- > t/lib/QA/TemplateFilters.pm | 9 +- > t/lib/Selenium.pm | 30 +- > t/lib/TestBuilder.pm | 30 +- > 27 files changed, 517 insertions(+), 679 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index 62c5d91d5f1..70921abfd13 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -95,7 +95,24 @@ BEGIN { > ); > } > >-=head2 GetOrderFromItemnumber >+=head1 NAME >+ >+C4::Acquisition - Koha functions for dealing with orders and acquisitions >+ >+=head1 SYNOPSIS >+ >+use C4::Acquisition; >+ >+=head1 DESCRIPTION >+ >+The functions in this module deal with acquisitions, managing book >+orders, basket and parcels. >+ >+=head1 FUNCTIONS >+ >+=head2 FUNCTIONS ABOUT BASKETS >+ >+=head3 GetOrderFromItemnumber > > Missing POD for GetOrderFromItemnumber. > >@@ -121,23 +138,6 @@ sub GetOrderFromItemnumber { > > } > >-=head1 NAME >- >-C4::Acquisition - Koha functions for dealing with orders and acquisitions >- >-=head1 SYNOPSIS >- >-use C4::Acquisition; >- >-=head1 DESCRIPTION >- >-The functions in this module deal with acquisitions, managing book >-orders, basket and parcels. >- >-=head1 FUNCTIONS >- >-=head2 FUNCTIONS ABOUT BASKETS >- > =head3 GetBasket > > $aqbasket = &GetBasket($basketnumber); >diff --git a/C4/Auth.pm b/C4/Auth.pm >index ab7625cfa3d..3881f4271dc 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -62,21 +62,6 @@ use Koha::Session; > use vars qw($ldap $cas $caslogout); > our ( @ISA, @EXPORT_OK ); > >-#NOTE: The utility of keeping the safe_exit function is that it can be easily re-defined in unit tests and plugins >- >-=head2 safe_exit >- >-Missing POD for safe_exit. >- >-=cut >- >-sub safe_exit { >- >- # It's fine for us to "exit" because CGI::Compile (used in Plack::App::WrapCGI) redefines "exit" for us automatically. >- # Since we only seem to use C4::Auth::safe_exit in a CGI context, we don't actually need PSGI detection at all here. >- exit; >-} >- > BEGIN { > C4::Context->set_remote_address; > >@@ -134,6 +119,46 @@ automatically. This gets loaded into the template. > > =head1 FUNCTIONS > >+=cut >+ >+=head2 safe_exit >+ >+Missing POD for safe_exit. >+ >+NOTE: The utility of keeping the safe_exit function is that it can be easily re-defined in unit tests and plugins >+ >+=cut >+ >+sub safe_exit { >+ >+ # It's fine for us to "exit" because CGI::Compile (used in Plack::App::WrapCGI) redefines "exit" for us automatically. >+ # Since we only seem to use C4::Auth::safe_exit in a CGI context, we don't actually need PSGI detection at all here. >+ exit; >+} >+ >+BEGIN { >+ C4::Context->set_remote_address; >+ >+ require Exporter; >+ @ISA = qw(Exporter); >+ >+ @EXPORT_OK = qw( >+ checkauth check_api_auth get_session check_cookie_auth checkpw checkpw_internal checkpw_hash >+ get_all_subpermissions get_cataloguing_page_permissions get_user_subpermissions in_iprange >+ get_template_and_user haspermission create_basic_session >+ ); >+ >+ $cas = C4::Context->preference('casAuthentication'); >+ $caslogout = C4::Context->preference('casLogout'); >+ >+ if ($cas) { >+ require C4::Auth_with_cas; # no import >+ import C4::Auth_with_cas >+ qw(check_api_auth_cas checkpw_cas login_cas logout_cas login_cas_url logout_if_required multipleAuth getMultipleAuth); >+ } >+ >+} >+ > =head2 get_template_and_user > > my ($template, $borrowernumber, $cookie) >diff --git a/C4/Auth_with_shibboleth.pm b/C4/Auth_with_shibboleth.pm >index 3bd2d1f96fd..ccaf9f1a085 100644 >--- a/C4/Auth_with_shibboleth.pm >+++ b/C4/Auth_with_shibboleth.pm >@@ -40,12 +40,6 @@ BEGIN { > > # Check that shib config is not malformed > >-=head2 shib_ok >- >-Missing POD for shib_ok. >- >-=cut >- > sub shib_ok { > my $config = _get_shib_config(); > >@@ -378,6 +372,10 @@ If you need more help configuring your B<S>ervice B<P>rovider to authenticate ag > > =head1 FUNCTIONS > >+=head2 shib_ok >+ >+Missing POD for shib_ok. >+ > =head2 logout_shib > > Sends a logout signal to the native shibboleth service provider and then logs out of koha. Depending upon the native service provider configuration and identity provider capabilities this may or may not perform a single sign out action. >diff --git a/C4/Barcodes.pm b/C4/Barcodes.pm >index c32f0355f9c..858aefe41f0 100644 >--- a/C4/Barcodes.pm >+++ b/C4/Barcodes.pm >@@ -40,54 +40,24 @@ sub _prefformat { > return $prefformat; > } > >-=head2 initial >- >-Missing POD for initial. >- >-=cut >- > sub initial { > return '0000001'; > } > >-=head2 width >- >-Missing POD for width. >- >-=cut >- > sub width { > return; > } > >-=head2 process_head >- >-Missing POD for process_head. >- >-=cut >- > sub process_head { # (self,head,whole,specific) > my $self = shift; > return shift; # Default: just return the head unchanged. > } > >-=head2 process_tail >- >-Missing POD for process_tail. >- >-=cut >- > sub process_tail { # (self,tail,whole,specific) > my $self = shift; > return shift; # Default: just return the tail unchanged. > } > >-=head2 is_max >- >-Missing POD for is_max. >- >-=cut >- > sub is_max { > my $self = shift; > ref($self) or carp "Called is_max on a non-object: '$self'"; >@@ -95,12 +65,6 @@ sub is_max { > return $self->{is_max} || 0; > } > >-=head2 value >- >-Missing POD for value. >- >-=cut >- > sub value { > my $self = shift; > if (@_) { >@@ -112,12 +76,6 @@ sub value { > return $self->{value}; > } > >-=head2 autoBarcode >- >-Missing POD for autoBarcode. >- >-=cut >- > sub autoBarcode { > (@_) or return _prefformat; > my $self = shift; >@@ -126,12 +84,6 @@ sub autoBarcode { > return $value; > } > >-=head2 parse >- >-Missing POD for parse. >- >-=cut >- > sub parse { # return 3 parts of barcode: non-incrementing, incrementing, non-incrementing > my $self = shift; > my $barcode = (@_) ? shift : $self->value; >@@ -142,12 +94,6 @@ sub parse { # return 3 parts of barcode: non-incrementing, incrementing, non- > return ( $1, $2, '' ); # the third part is in anticipation of barcodes that include checkdigits > } > >-=head2 max >- >-Missing POD for max. >- >-=cut >- > sub max { > my $self = shift; > if ( $self->{is_max} ) { >@@ -156,12 +102,6 @@ sub max { > return $self->db_max; > } > >-=head2 db_max >- >-Missing POD for db_max. >- >-=cut >- > sub db_max { > my $self = shift; > my $query = "SELECT max(abs(CAST(barcode AS UNSIGNED))) FROM items LIMIT 1" >@@ -171,12 +111,6 @@ sub db_max { > return $sth->fetchrow_array || $self->initial; > } > >-=head2 next_value >- >-Missing POD for next_value. >- >-=cut >- > sub next_value { > my $self = shift; > my $specific = ( scalar @_ ) ? 1 : 0; >@@ -202,48 +136,24 @@ sub next_value { > return $next_value; > } > >-=head2 next >- >-Missing POD for next. >- >-=cut >- > sub next { > my $self = shift or return; > (@_) and $self->{next} = shift; > return $self->{next}; > } > >-=head2 previous >- >-Missing POD for previous. >- >-=cut >- > sub previous { > my $self = shift or return; > (@_) and $self->{previous} = shift; > return $self->{previous}; > } > >-=head2 serial >- >-Missing POD for serial. >- >-=cut >- > sub serial { > my $self = shift or return; > (@_) and $self->{serial} = shift; > return $self->{serial}; > } > >-=head2 default_self >- >-Missing POD for default_self. >- >-=cut >- > sub default_self { > (@_) or carp "default_self called with no argument. Reverting to _prefformat."; > my $autoBarcode = (@_) ? shift : _prefformat; >@@ -311,12 +221,6 @@ sub new { > return; > } > >-=head2 new_object >- >-Missing POD for new_object. >- >-=cut >- > sub new_object { > my $class_or_object = shift; > my $type = ref($class_or_object) || $class_or_object; >@@ -369,5 +273,70 @@ like the IBM "Boulder" format can cause problems for sprintf. Basically, the va > %d version of an integer, and we cannot count on perl having been compiled with support for quads > (64-bit integers). So we have to use floats or increment a piece of it and return the rejoined fragments. > >-=cut >+=head1 Functions > >+=head2 initial >+ >+Missing POD for initial. >+ >+=head2 width >+ >+Missing POD for width. >+ >+=head2 process_head >+ >+Missing POD for process_head. >+ >+=head2 process_tail >+ >+Missing POD for process_tail. >+ >+=head2 is_max >+ >+Missing POD for is_max. >+ >+=head2 value >+ >+Missing POD for value. >+ >+=head2 autoBarcode >+ >+Missing POD for autoBarcode. >+ >+=head2 parse >+ >+Missing POD for parse. >+ >+=head2 max >+ >+Missing POD for max. >+ >+=head2 db_max >+ >+Missing POD for db_max. >+ >+=head2 next_value >+ >+Missing POD for next_value. >+ >+=head2 next >+ >+Missing POD for next. >+ >+=head2 previous >+ >+Missing POD for previous. >+ >+=head2 serial >+ >+Missing POD for serial. >+ >+=head2 default_self >+ >+Missing POD for default_self. >+ >+=head2 new_object >+ >+Missing POD for new_object. >+ >+=cut >diff --git a/C4/Barcodes/hbyymmincr.pm b/C4/Barcodes/hbyymmincr.pm >index d3f1704a081..7136dcb8fbb 100644 >--- a/C4/Barcodes/hbyymmincr.pm >+++ b/C4/Barcodes/hbyymmincr.pm >@@ -34,6 +34,10 @@ BEGIN { > @ISA = qw(C4::Barcodes); > } > >+=head1 Functions >+ >+=cut >+ > # Generates barcode where hb = home branch Code, yymm = year/month catalogued, incr = incremental number, > # increment resets yearly -fbcit > >diff --git a/C4/Creators/PDF.pm b/C4/Creators/PDF.pm >index d067cd6f7a6..4d3754d3718 100644 >--- a/C4/Creators/PDF.pm >+++ b/C4/Creators/PDF.pm >@@ -61,6 +61,10 @@ sub _InitVars { > prInitVars($param); > } > >+=head1 Functions >+ >+=cut >+ > =head2 new > > Missing POD for new. >diff --git a/C4/Creators/Template.pm b/C4/Creators/Template.pm >index d75e9adc8b4..4457cbc67b9 100644 >--- a/C4/Creators/Template.pm >+++ b/C4/Creators/Template.pm >@@ -266,12 +266,6 @@ sub get_label_position { > } > } > >-=head2 get_next_label_pos >- >-Missing POD for get_next_label_pos. >- >-=cut >- > sub get_next_label_pos { > my $self = shift; > my $current_label = $self->{'current_label'}; >@@ -417,6 +411,10 @@ CM = SI Centimeters (28.3464567 points per) > examples: > C<my ($row_count, $col_count, $llx, $lly) = $template->get_label_position($start_label);> > >+=head2 get_next_label_pos >+ >+Missing POD for get_next_label_pos. >+ > =head1 AUTHOR > > Chris Nighswonger <cnighswonger AT foundations DOT edu> >diff --git a/C4/External/BakerTaylor.pm b/C4/External/BakerTaylor.pm >index b37e71d0643..c9735a02306 100644 >--- a/C4/External/BakerTaylor.pm >+++ b/C4/External/BakerTaylor.pm >@@ -49,12 +49,6 @@ sub _initialize { > #"Mozilla/4.76 [en] (Win98; U)", # if for some reason you want to go stealth, you might prefer this > } > >-=head2 image_url >- >-Missing POD for image_url. >- >-=cut >- > sub image_url { > _initialize(); > ( $user and $pass ) or return; >@@ -63,12 +57,6 @@ sub image_url { > return $image_url . $isbn; > } > >-=head2 link_url >- >-Missing POD for link_url. >- >-=cut >- > sub link_url { > _initialize(); > my $isbn = ( @_ ? shift : '' ); >@@ -77,12 +65,6 @@ sub link_url { > return $link_url . $isbn; > } > >-=head2 content_cafe_url >- >-Missing POD for content_cafe_url. >- >-=cut >- > sub content_cafe_url { > _initialize(); > ( $user and $pass ) or return; >@@ -92,12 +74,6 @@ sub content_cafe_url { > "https://contentcafe2.btol.com/ContentCafeClient/ContentCafe.aspx?UserID=$user&Password=$pass&Options=Y&ItemKey=$isbn"; > } > >-=head2 http_jacket_link >- >-Missing POD for http_jacket_link. >- >-=cut >- > sub http_jacket_link { > _initialize(); > my $isbn = shift or return; >@@ -147,6 +123,22 @@ These can be overridden for testing purposes using the initialize function. > > =head1 FUNCTIONS > >+=head2 image_url >+ >+Missing POD for image_url. >+ >+=head2 link_url >+ >+Missing POD for link_url. >+ >+=head2 content_cafe_url >+ >+Missing POD for content_cafe_url. >+ >+=head2 http_jacket_link >+ >+Missing POD for http_jacket_link. >+ > =head2 availability($isbn); > > $isbn is a isbn string >diff --git a/C4/Installer/PerlModules.pm b/C4/Installer/PerlModules.pm >index 2342b89bf69..da63294bec3 100644 >--- a/C4/Installer/PerlModules.pm >+++ b/C4/Installer/PerlModules.pm >@@ -19,12 +19,6 @@ sub new { > return $self; > } > >-=head2 prereqs >- >-Missing POD for prereqs. >- >-=cut >- > sub prereqs { > my $self = shift; > >@@ -125,6 +119,10 @@ A module for manipulating Koha Perl dependency list objects. > example: > C<my $perl_modules = C4::Installer::PerlModules->new;> > >+=head2 prereqs >+ >+Missing POD for prereqs. >+ > =head2 prereq_pm() > > Returns a hashref of a hash of module information suitable for use in Makefile.PL >diff --git a/C4/Labels/Label.pm b/C4/Labels/Label.pm >index 4abe14a8f35..e69ec3633bc 100644 >--- a/C4/Labels/Label.pm >+++ b/C4/Labels/Label.pm >@@ -504,12 +504,6 @@ LABEL_FIELDS: # process data for requested fields on current label > return \@label_text; > } > >-=head2 draw_guide_box >- >-Missing POD for draw_guide_box. >- >-=cut >- > sub draw_guide_box { > return $_[0]->{'guidebox'}; > } >@@ -802,6 +796,10 @@ R = Right > justify => $text_justification, > );> > >+=head2 draw_guide_box >+ >+Missing POD for draw_guide_box. >+ > =head2 barcode() > > Invoking the I<barcode> method generates a barcode for the label object and inserts it into the current pdf stream. This method accepts the following parameters as key => value >diff --git a/C4/Linker/Default.pm b/C4/Linker/Default.pm >index 72476e3b082..7870713ba4e 100644 >--- a/C4/Linker/Default.pm >+++ b/C4/Linker/Default.pm >@@ -24,6 +24,10 @@ use C4::Heading; > > use base qw(C4::Linker); > >+=head1 Functions >+ >+=cut >+ > =head2 get_link > > Missing POD for get_link. >diff --git a/C4/Linker/FirstMatch.pm b/C4/Linker/FirstMatch.pm >index 378ea095372..a00e32978b3 100644 >--- a/C4/Linker/FirstMatch.pm >+++ b/C4/Linker/FirstMatch.pm >@@ -24,6 +24,10 @@ use C4::Linker::Default; # Use Default for flipping > > use base qw(C4::Linker); > >+=head1 Functions >+ >+=cut >+ > =head2 new > > Missing POD for new. >diff --git a/C4/Linker/LastMatch.pm b/C4/Linker/LastMatch.pm >index 60f0de51208..00366981267 100644 >--- a/C4/Linker/LastMatch.pm >+++ b/C4/Linker/LastMatch.pm >@@ -24,6 +24,10 @@ use C4::Linker::Default; # Use Default for flipping > > use base qw(C4::Linker); > >+=head1 Functions >+ >+=cut >+ > =head2 new > > Missing POD for new. >diff --git a/C4/Output.pm b/C4/Output.pm >index 2e34ee6f321..a98170a3607 100644 >--- a/C4/Output.pm >+++ b/C4/Output.pm >@@ -276,7 +276,7 @@ sub output_with_http_headers { > print $query->header($options), $data; > } > >-=head2 output_html_with_http_headers >+=item output_html_with_http_headers > > Missing POD for output_html_with_http_headers. > >@@ -287,7 +287,7 @@ sub output_html_with_http_headers { > output_with_http_headers( $query, $cookie, $data, 'html', $status, $extra_options ); > } > >-=head2 output_ajax_with_http_headers >+=item output_ajax_with_http_headers > > Missing POD for output_ajax_with_http_headers. > >@@ -304,7 +304,7 @@ sub output_ajax_with_http_headers { > ), $js; > } > >-=head2 is_ajax >+=item is_ajax > > Missing POD for is_ajax. > >@@ -387,7 +387,7 @@ sub output_and_exit { > exit; > } > >-=head2 output_error >+=item output_error > > Missing POD for output_error. > >@@ -411,7 +411,7 @@ sub output_error { > output_with_http_headers $query, $cookie, $template->output, 'html', '404 Not Found'; > } > >-=head2 parametrized_url >+=item parametrized_url > > Missing POD for parametrized_url. > >diff --git a/C4/Patroncards/Lib.pm b/C4/Patroncards/Lib.pm >index a709a3fb902..85dccc967b3 100644 >--- a/C4/Patroncards/Lib.pm >+++ b/C4/Patroncards/Lib.pm >@@ -84,12 +84,6 @@ sub box { > $pdf->Add($obj_stream); > } > >-=head2 get_borrower_attributes >- >-Missing POD for get_borrower_attributes. >- >-=cut >- > sub get_borrower_attributes { > my ( $borrower_number, @fields ) = @_; > my $get_branch = 0; >@@ -123,12 +117,6 @@ sub get_borrower_attributes { > return $borrower_attributes; > } > >-=head2 put_image >- >-Missing POD for put_image. >- >-=cut >- > sub put_image { > my ( $image_name, $image_file ) = @_; > if ( my $image_limit = C4::Context->preference('ImageLimit') ) { # enforce quota if set >@@ -152,12 +140,6 @@ sub put_image { > return; > } > >-=head2 get_image >- >-Missing POD for get_image. >- >-=cut >- > sub get_image { > my ( $image_name, $fields ) = @_; > $fields = '*' unless $fields; >@@ -176,12 +158,6 @@ sub get_image { > return $sth->fetchall_arrayref( {} ); > } > >-=head2 rm_image >- >-Missing POD for rm_image. >- >-=cut >- > sub rm_image { > my $image_ids = shift; > my $errstr = (); >@@ -276,7 +252,21 @@ This library provides functions used by various sections of the Patroncard Creat > > box($llx, $lly, $width, $height, $pdf); > >-=cut >+=head2 get_borrower_attributes >+ >+Missing POD for get_borrower_attributes. >+ >+=head2 put_image >+ >+Missing POD for put_image. >+ >+=head2 get_image >+ >+Missing POD for get_image. >+ >+=head2 rm_image >+ >+Missing POD for rm_image. > > =head1 AUTHOR > >diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm >index f3702c7b91a..dec0a590c3d 100644 >--- a/C4/SIP/ILS.pm >+++ b/C4/SIP/ILS.pm >@@ -47,6 +47,10 @@ my %supports = ( > "renew all" => 1, > ); > >+=head1 Functions >+ >+=cut >+ > =head2 new > > Missing POD for new. >diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm >index 10b688bc91a..f222401e4e7 100644 >--- a/C4/SIP/ILS/Transaction/Checkin.pm >+++ b/C4/SIP/ILS/Transaction/Checkin.pm >@@ -33,6 +33,10 @@ my %fields = ( > hold => undef, > ); > >+=head1 Functions >+ >+=cut >+ > =head2 new > > Missing POD for new. >diff --git a/C4/Scrubber.pm b/C4/Scrubber.pm >index 856dcb62549..f09fb998e49 100644 >--- a/C4/Scrubber.pm >+++ b/C4/Scrubber.pm >@@ -37,12 +37,6 @@ my %scrubbertypes = ( > }, > ); > >-=head2 new >- >-Missing POD for new. >- >-=cut >- > sub new { > shift; # ignore our class we are wrapper > my $type = (@_) ? shift : 'default'; >@@ -71,7 +65,10 @@ Standardized wrapper with settings for building HTML::Scrubber tailored to vario > The default is to scrub everything, leaving no markup at all. This is compatible with the expectations > for Tags. > >-=head2 TODO: Add real perldoc >+=head1 Functions > >-=cut >+=head2 new > >+Missing POD for new. >+ >+=cut >diff --git a/C4/Search/History.pm b/C4/Search/History.pm >index 69c114f20be..6761a73b02a 100644 >--- a/C4/Search/History.pm >+++ b/C4/Search/History.pm >@@ -118,12 +118,6 @@ sub delete { > ); > } > >-=head2 delete_from_cookie >- >-Missing POD for delete_from_cookie. >- >-=cut >- > sub delete_from_cookie { > my ($params) = @_; > my $cookie = $params->{cookie}; >@@ -292,6 +286,10 @@ It is possible to delete searches for current session or all previous sessions u > If the type ("biblio" or "authority") is missing, all type will be deleted. > To delete *all* searches for a given userid, just pass a userid. > >+=head2 delete_from_cookie >+ >+Missing POD for delete_from_cookie. >+ > =head2 get > > my $searches C4::Search::History::get({ >diff --git a/Koha/Edifact/Line.pm b/Koha/Edifact/Line.pm >index 6ef6227adc8..571b9e67b75 100644 >--- a/Koha/Edifact/Line.pm >+++ b/Koha/Edifact/Line.pm >@@ -176,12 +176,6 @@ sub _format_item_description { > return $bibrec; > } > >-=head2 marc_record >- >-Missing POD for marc_record. >- >-=cut >- > sub marc_record { > my $self = shift; > my $b = $self->{item_description}; >@@ -276,12 +270,6 @@ sub marc_record { > return $bib; > } > >-=head2 corpcon >- >-Missing POD for corpcon. >- >-=cut >- > sub corpcon { > my ( $self, $level ) = @_; > my $test_these = { >@@ -315,12 +303,6 @@ sub corpcon { > return new_field( $self->{item_description}, [ $tag, $i1, $i2 ], @spec ); > } > >-=head2 new_field >- >-Missing POD for new_field. >- >-=cut >- > sub new_field { > my ( $b, $tag_ind, @sfd_elem ) = @_; > my @sfd; >@@ -340,45 +322,21 @@ sub new_field { > > # Accessor methods to line data > >-=head2 item_number_id >- >-Missing POD for item_number_id. >- >-=cut >- > sub item_number_id { > my $self = shift; > return $self->{item_number_id}; > } > >-=head2 line_item_number >- >-Missing POD for line_item_number. >- >-=cut >- > sub line_item_number { > my $self = shift; > return $self->{line_item_number}; > } > >-=head2 additional_product_ids >- >-Missing POD for additional_product_ids. >- >-=cut >- > sub additional_product_ids { > my $self = shift; > return $self->{additional_product_ids}; > } > >-=head2 action_notification >- >-Missing POD for action_notification. >- >-=cut >- > sub action_notification { > my $self = shift; > my $a = $self->{action_notification}; >@@ -388,155 +346,71 @@ sub action_notification { > return $a; > } > >-=head2 item_description >- >-Missing POD for item_description. >- >-=cut >- > sub item_description { > my $self = shift; > return $self->{item_description}; > } > >-=head2 monetary_amount >- >-Missing POD for monetary_amount. >- >-=cut >- > sub monetary_amount { > my $self = shift; > return $self->{monetary_amount}; > } > >-=head2 quantity >- >-Missing POD for quantity. >- >-=cut >- > sub quantity { > my $self = shift; > return $self->{quantity}; > } > >-=head2 quantity_invoiced >- >-Missing POD for quantity_invoiced. >- >-=cut >- > sub quantity_invoiced { > my $self = shift; > return $self->{quantity_invoiced}; > } > >-=head2 price >- >-Missing POD for price. >- >-=cut >- > sub price { > my $self = shift; > return $self->{price}; > } > >-=head2 reference >- >-Missing POD for reference. >- >-=cut >- > sub reference { > my $self = shift; > return $self->{reference}; > } > >-=head2 orderline_reference_number >- >-Missing POD for orderline_reference_number. >- >-=cut >- > sub orderline_reference_number { > my $self = shift; > return $self->{orderline_reference_number}; > } > >-=head2 ordernumber >- >-Missing POD for ordernumber. >- >-=cut >- > sub ordernumber { > my $self = shift; > return $self->{ordernumber}; > } > >-=head2 free_text >- >-Missing POD for free_text. >- >-=cut >- > sub free_text { > my $self = shift; > return $self->{free_text}; > } > >-=head2 coded_free_text >- >-Missing POD for coded_free_text. >- >-=cut >- > sub coded_free_text { > my $self = shift; > return $self->{coded_free_text}->{code}; > } > >-=head2 internal_notes >- >-Missing POD for internal_notes. >- >-=cut >- > sub internal_notes { > my $self = shift; > return $self->{internal_notes}; > } > >-=head2 coded_internal_note >- >-Missing POD for coded_internal_note. >- >-=cut >- > sub coded_internal_note { > my $self = shift; > return $self->{coded_internal_note}->{code}; > } > >-=head2 orderline_free_text >- >-Missing POD for orderline_free_text. >- >-=cut >- > sub orderline_free_text { > my $self = shift; > return $self->{orderline_free_text}; > } > >-=head2 coded_orderline_text >- >-Missing POD for coded_orderline_text. >- >-=cut >- > sub coded_orderline_text { > my $self = shift; > my $code = $self->{coded_orderline_text}->{code}; >@@ -553,23 +427,11 @@ sub coded_orderline_text { > return $txt; > } > >-=head2 substitute_free_text >- >-Missing POD for substitute_free_text. >- >-=cut >- > sub substitute_free_text { > my $self = shift; > return $self->{substitute_free_text}; > } > >-=head2 coded_substitute_text >- >-Missing POD for coded_substitute_text. >- >-=cut >- > sub coded_substitute_text { > my $self = shift; > return $self->{coded_substitute_text}->{code}; >@@ -579,12 +441,6 @@ sub coded_substitute_text { > # by (orderline|substitue)-free_text (FTX seg LIN) > # and expand it using EditEUR code list 8B > >-=head2 translate_8B >- >-Missing POD for translate_8B. >- >-=cut >- > sub translate_8B { > my ($code) = @_; > >@@ -632,12 +488,6 @@ sub translate_8B { > } > } > >-=head2 translate_12B >- >-Missing POD for translate_12B. >- >-=cut >- > sub translate_12B { > my ($code) = @_; > >@@ -693,12 +543,6 @@ sub translate_12B { > > # item_desription_fields accessors > >-=head2 title >- >-Missing POD for title. >- >-=cut >- > sub title { > my $self = shift; > my $titlefield = q{050}; >@@ -708,12 +552,6 @@ sub title { > return; > } > >-=head2 author >- >-Missing POD for author. >- >-=cut >- > sub author { > my $self = shift; > my $field = q{010}; >@@ -729,12 +567,6 @@ sub author { > return; > } > >-=head2 series >- >-Missing POD for series. >- >-=cut >- > sub series { > my $self = shift; > my $field = q{190}; >@@ -744,12 +576,6 @@ sub series { > return; > } > >-=head2 publisher >- >-Missing POD for publisher. >- >-=cut >- > sub publisher { > my $self = shift; > my $field = q{120}; >@@ -759,12 +585,6 @@ sub publisher { > return; > } > >-=head2 publication_date >- >-Missing POD for publication_date. >- >-=cut >- > sub publication_date { > my $self = shift; > my $field = q{170}; >@@ -774,12 +594,6 @@ sub publication_date { > return; > } > >-=head2 dewey_class >- >-Missing POD for dewey_class. >- >-=cut >- > sub dewey_class { > my $self = shift; > my $field = q{230}; >@@ -789,12 +603,6 @@ sub dewey_class { > return; > } > >-=head2 lc_class >- >-Missing POD for lc_class. >- >-=cut >- > sub lc_class { > my $self = shift; > my $field = q{240}; >@@ -804,12 +612,6 @@ sub lc_class { > return; > } > >-=head2 girfield >- >-Missing POD for girfield. >- >-=cut >- > sub girfield { > my ( $self, $field, $occ ) = @_; > if ( $self->number_of_girs ) { >@@ -825,12 +627,6 @@ sub girfield { > } > } > >-=head2 number_of_girs >- >-Missing POD for number_of_girs. >- >-=cut >- > sub number_of_girs { > my $self = shift; > if ( $self->{GIR} ) { >@@ -843,12 +639,6 @@ sub number_of_girs { > } > } > >-=head2 extract_gir >- >-Missing POD for extract_gir. >- >-=cut >- > sub extract_gir { > my $s = shift; > my %qmap = ( >@@ -896,12 +686,6 @@ sub extract_gir { > > # mainly for invoice processing amt_ will derive from MOA price_ from PRI and tax_ from TAX/MOA pairsn > >-=head2 moa_amt >- >-Missing POD for moa_amt. >- >-=cut >- > sub moa_amt { > my ( $self, $qualifier ) = @_; > foreach my $s ( @{ $self->{segs} } ) { >@@ -912,12 +696,6 @@ sub moa_amt { > return; > } > >-=head2 moa_multiple_amt >- >-Missing POD for moa_multiple_amt. >- >-=cut >- > sub moa_multiple_amt { > my ( $self, $qualifier ) = @_; > >@@ -936,23 +714,11 @@ sub moa_multiple_amt { > return; > } > >-=head2 amt_discount >- >-Missing POD for amt_discount. >- >-=cut >- > sub amt_discount { > my $self = shift; > return $self->moa_amt('52'); > } > >-=head2 amt_prepayment >- >-Missing POD for amt_prepayment. >- >-=cut >- > sub amt_prepayment { > my $self = shift; > return $self->moa_amt('113'); >@@ -960,12 +726,6 @@ sub amt_prepayment { > > # total including allowances & tax > >-=head2 amt_total >- >-Missing POD for amt_total. >- >-=cut >- > sub amt_total { > my $self = shift; > return $self->moa_amt('128'); >@@ -973,12 +733,6 @@ sub amt_total { > > # Used to give price in currency other than that given in price > >-=head2 amt_unitprice >- >-Missing POD for amt_unitprice. >- >-=cut >- > sub amt_unitprice { > my $self = shift; > return $self->moa_amt('146'); >@@ -986,34 +740,16 @@ sub amt_unitprice { > > # item amount after allowances excluding tax > >-=head2 amt_lineitem >- >-Missing POD for amt_lineitem. >- >-=cut >- > sub amt_lineitem { > my $self = shift; > return $self->moa_amt('203'); > } > >-=head2 amt_taxoncharge >- >-Missing POD for amt_taxoncharge. >- >-=cut >- > sub amt_taxoncharge { > my $self = shift; > return $self->moa_multiple_amt('124'); > } > >-=head2 pri_price >- >-Missing POD for pri_price. >- >-=cut >- > sub pri_price { > my ( $self, $price_qualifier ) = @_; > >@@ -1044,12 +780,6 @@ sub pri_price { > > # unit price that will be chaged excl tax > >-=head2 price_net >- >-Missing POD for price_net. >- >-=cut >- > sub price_net { > my $self = shift; > my $p = $self->pri_price('AAA'); >@@ -1061,12 +791,6 @@ sub price_net { > > # unit price excluding all allowances, charges and taxes > >-=head2 price_gross >- >-Missing POD for price_gross. >- >-=cut >- > sub price_gross { > my $self = shift; > my $p = $self->pri_price('AAB'); >@@ -1078,12 +802,6 @@ sub price_gross { > > # information price incl tax excluding allowances, charges > >-=head2 price_info >- >-Missing POD for price_info. >- >-=cut >- > sub price_info { > my $self = shift; > my $p = $self->pri_price('AAE'); >@@ -1095,12 +813,6 @@ sub price_info { > > # information price incl tax,allowances, charges > >-=head2 price_info_inclusive >- >-Missing POD for price_info_inclusive. >- >-=cut >- > sub price_info_inclusive { > my $self = shift; > my $p = $self->pri_price('AAF'); >@@ -1110,23 +822,11 @@ sub price_info_inclusive { > return; > } > >-=head2 tax >- >-Missing POD for tax. >- >-=cut >- > sub tax { > my $self = shift; > return $self->moa_amt('124'); > } > >-=head2 tax_rate >- >-Missing POD for tax_rate. >- >-=cut >- > sub tax_rate { > my $self = shift; > my $tr = {}; >@@ -1152,12 +852,6 @@ sub tax_rate { > return; > } > >-=head2 availability_date >- >-Missing POD for availability_date. >- >-=cut >- > sub availability_date { > my $self = shift; > if ( exists $self->{availability_date} ) { >@@ -1208,6 +902,214 @@ Koha::Edifact::Line > > Called with an array ref of segments constituting the line > >+ >+=head2 marc_record >+ >+Missing POD for marc_record. >+ >+ >+=head2 corpcon >+ >+Missing POD for corpcon. >+ >+=head2 new_field >+ >+Missing POD for new_field. >+ >+ >+=head2 item_number_id >+ >+Missing POD for item_number_id. >+ >+ >+=head2 line_item_number >+ >+Missing POD for line_item_number. >+ >+=head2 additional_product_ids >+ >+Missing POD for additional_product_ids. >+ >+=head2 action_notification >+ >+Missing POD for action_notification. >+ >+=head2 item_description >+ >+Missing POD for item_description. >+ >+=head2 monetary_amount >+ >+Missing POD for monetary_amount. >+ >+=head2 quantity >+ >+Missing POD for quantity. >+ >+=head2 quantity_invoiced >+ >+Missing POD for quantity_invoiced. >+ >+=head2 price >+ >+Missing POD for price. >+ >+=head2 reference >+ >+Missing POD for reference. >+ >+=head2 orderline_reference_number >+ >+Missing POD for orderline_reference_number. >+ >+=head2 ordernumber >+ >+Missing POD for ordernumber. >+ >+=head2 free_text >+ >+Missing POD for free_text. >+ >+=head2 coded_free_text >+ >+Missing POD for coded_free_text. >+ >+=head2 internal_notes >+ >+Missing POD for internal_notes. >+ >+=head2 coded_internal_note >+ >+Missing POD for coded_internal_note. >+ >+=head2 orderline_free_text >+ >+Missing POD for orderline_free_text. >+ >+=head2 coded_orderline_text >+ >+Missing POD for coded_orderline_text. >+ >+=head2 substitute_free_text >+ >+Missing POD for substitute_free_text. >+ >+=head2 coded_substitute_text >+ >+Missing POD for coded_substitute_text. >+ >+=head2 translate_8B >+ >+Missing POD for translate_8B. >+ >+=head2 translate_12B >+ >+Missing POD for translate_12B. >+ >+=head2 title >+ >+Missing POD for title. >+ >+=head2 author >+ >+Missing POD for author. >+ >+=head2 series >+ >+Missing POD for series. >+ >+=head2 publisher >+ >+Missing POD for publisher. >+ >+=head2 publication_date >+ >+Missing POD for publication_date. >+ >+=head2 dewey_class >+ >+Missing POD for dewey_class. >+ >+=head2 lc_class >+ >+Missing POD for lc_class. >+ >+=head2 girfield >+ >+Missing POD for girfield. >+ >+=head2 number_of_girs >+ >+Missing POD for number_of_girs. >+ >+=head2 extract_gir >+ >+Missing POD for extract_gir. >+ >+=head2 moa_amt >+ >+Missing POD for moa_amt. >+ >+=head2 moa_multiple_amt >+ >+Missing POD for moa_multiple_amt. >+ >+=head2 amt_discount >+ >+Missing POD for amt_discount. >+ >+=head2 amt_prepayment >+ >+Missing POD for amt_prepayment. >+ >+=head2 amt_total >+ >+Missing POD for amt_total. >+ >+=head2 amt_unitprice >+ >+Missing POD for amt_unitprice. >+ >+=head2 amt_lineitem >+ >+Missing POD for amt_lineitem. >+ >+=head2 amt_taxoncharge >+ >+Missing POD for amt_taxoncharge. >+ >+=head2 pri_price >+ >+Missing POD for pri_price. >+ >+=head2 price_net >+ >+Missing POD for price_net. >+ >+=head2 price_gross >+ >+Missing POD for price_gross. >+ >+=head2 price_info >+ >+Missing POD for price_info. >+ >+=head2 price_info_inclusive >+ >+Missing POD for price_info_inclusive. >+ >+=head2 tax >+ >+Missing POD for tax. >+ >+=head2 tax_rate >+ >+Missing POD for tax_rate. >+ >+=head2 availability_date >+ >+Missing POD for availability_date. >+ > =head1 AUTHOR > > Colin Campbell <colin.campbell@ptfs-europe.com> >diff --git a/Koha/Edifact/Message.pm b/Koha/Edifact/Message.pm >index af2a4397838..4bff73c75d3 100644 >--- a/Koha/Edifact/Message.pm >+++ b/Koha/Edifact/Message.pm >@@ -46,23 +46,11 @@ sub new { > return $self; > } > >-=head2 message_refno >- >-Missing POD for message_refno. >- >-=cut >- > sub message_refno { > my $self = shift; > return $self->{message_reference_number}; > } > >-=head2 function >- >-Missing POD for function. >- >-=cut >- > sub function { > my $self = shift; > my $msg_function = $self->{bgm}->elem(2); >@@ -74,56 +62,26 @@ sub function { > return; > } > >-=head2 message_reference_number >- >-Missing POD for message_reference_number. >- >-=cut >- > sub message_reference_number { > my $self = shift; > return $self->{header}->elem(0); > } > >-=head2 message_type >- >-Missing POD for message_type. >- >-=cut >- > sub message_type { > my $self = shift; > return $self->{header}->elem( 1, 0 ); > } > >-=head2 message_code >- >-Missing POD for message_code. >- >-=cut >- > sub message_code { > my $self = shift; > return $self->{bgm}->elem( 0, 0 ); > } > >-=head2 docmsg_number >- >-Missing POD for docmsg_number. >- >-=cut >- > sub docmsg_number { > my $self = shift; > return $self->{bgm}->elem(1); > } > >-=head2 message_date >- >-Missing POD for message_date. >- >-=cut >- > sub message_date { > my $self = shift; > >@@ -136,12 +94,6 @@ sub message_date { > return; # this should not happen > } > >-=head2 tax_point_date >- >-Missing POD for tax_point_date. >- >-=cut >- > sub tax_point_date { > my $self = shift; > if ( $self->message_type eq 'INVOIC' ) { >@@ -154,12 +106,6 @@ sub tax_point_date { > return; > } > >-=head2 expiry_date >- >-Missing POD for expiry_date. >- >-=cut >- > sub expiry_date { > my $self = shift; > if ( $self->message_type eq 'QUOTES' ) { >@@ -172,12 +118,6 @@ sub expiry_date { > return; > } > >-=head2 shipment_charge >- >-Missing POD for shipment_charge. >- >-=cut >- > sub shipment_charge { > my $self = shift; > >@@ -210,12 +150,6 @@ sub shipment_charge { > > # return NAD fields > >-=head2 buyer_ean >- >-Missing POD for buyer_ean. >- >-=cut >- > sub buyer_ean { > my $self = shift; > foreach my $s ( @{ $self->{datasegs} } ) { >@@ -232,12 +166,6 @@ sub buyer_ean { > return; > } > >-=head2 supplier_ean >- >-Missing POD for supplier_ean. >- >-=cut >- > sub supplier_ean { > my $self = shift; > foreach my $s ( @{ $self->{datasegs} } ) { >@@ -255,12 +183,6 @@ sub supplier_ean { > > } > >-=head2 lineitems >- >-Missing POD for lineitems. >- >-=cut >- > sub lineitems { > my $self = shift; > if ( $self->{quotation_lines} ) { >@@ -310,6 +232,54 @@ Class modelling an Edifact Message for parsing > Passed an array of segments extracts message level info > and parses lineitems as Line objects > >+=head2 message_refno >+ >+Missing POD for message_refno. >+ >+=head2 function >+ >+Missing POD for function. >+ >+=head2 message_reference_number >+ >+Missing POD for message_reference_number. >+ >+=head2 message_type >+ >+Missing POD for message_type. >+ >+=head2 message_code >+ >+Missing POD for message_code. >+ >+=head2 docmsg_number >+ >+Missing POD for docmsg_number. >+ >+=head2 tax_point_date >+ >+Missing POD for tax_point_date. >+ >+=head2 expiry_date >+ >+Missing POD for expiry_date. >+ >+=head2 shipment_charge >+ >+Missing POD for shipment_charge. >+ >+=head2 buyer_ean >+ >+Missing POD for buyer_ean. >+ >+=head2 supplier_ean >+ >+Missing POD for supplier_ean. >+ >+=head2 lineitems >+ >+Missing POD for lineitems. >+ > =head1 AUTHOR > > Colin Campbell <colin.campbell@ptfs-europe.com> >diff --git a/Koha/Edifact/Transport.pm b/Koha/Edifact/Transport.pm >index 082382935f9..a26f2842ffb 100644 >--- a/Koha/Edifact/Transport.pm >+++ b/Koha/Edifact/Transport.pm >@@ -88,12 +88,6 @@ sub upload_messages { > return; > } > >-=head2 file_download >- >-Missing POD for file_download. >- >-=cut >- > sub file_download { > my $self = shift; > my @downloaded_files; >@@ -351,12 +345,6 @@ sub sftp_upload { > return; > } > >-=head2 file_upload >- >-Missing POD for file_upload. >- >-=cut >- > sub file_upload { > my ( $self, @messages ) = @_; > my $dir = $self->{account}->upload_directory; >@@ -418,12 +406,6 @@ sub _get_file_ext { > return 'XXXX'; # non matching type > } > >-=head2 message_hash >- >-Missing POD for message_hash. >- >-=cut >- > sub message_hash { > my $self = shift; > my $msg = { >@@ -478,6 +460,10 @@ Or FILE to access a local directory (useful for testing) > > passed an array of messages will upload them to the supplier site > >+=head2 file_download >+ >+Missing POD for file_download. >+ > =head2 sftp_download > > called by download_messages to perform the download using SFTP >@@ -498,6 +484,10 @@ Or FILE to access a local directory (useful for testing) > > called by upload_messages to perform the upload using sftp > >+=head2 file_upload >+ >+Missing POD for file_upload. >+ > =head2 _abort_download > > internal routine to halt operation on error and supply a stacktrace >@@ -512,6 +502,10 @@ Or FILE to access a local directory (useful for testing) > sets the direct ingest flag so that the object reads files from > the local file system useful in debugging > >+=head2 message_hash >+ >+Missing POD for message_hash. >+ > =head1 AUTHOR > > Colin Campbell <colin.campbell@ptfs-europe.com> >diff --git a/Koha/Patron/Files.pm b/Koha/Patron/Files.pm >index 178b0f7badf..8735ea8095a 100644 >--- a/Koha/Patron/Files.pm >+++ b/Koha/Patron/Files.pm >@@ -32,7 +32,7 @@ Koha::Patron::Files - Module for managing patron files > > =cut > >-=head2 new >+=item new > > Missing POD for new. > >diff --git a/Koha/Template/Plugin/AuthorisedValues.pm b/Koha/Template/Plugin/AuthorisedValues.pm >index 8f3841ba753..5fe23da19c4 100644 >--- a/Koha/Template/Plugin/AuthorisedValues.pm >+++ b/Koha/Template/Plugin/AuthorisedValues.pm >@@ -35,12 +35,6 @@ sub GetByCode { > : $code; > } > >-=head2 Get >- >-Missing POD for Get. >- >-=cut >- > sub Get { > my ( $self, $category, $selected, $opac ) = @_; > return GetAuthorisedValues( $category, $selected, $opac ); >@@ -60,12 +54,6 @@ sub GetAuthValueDropbox { > ); > } > >-=head2 GetCategories >- >-Missing POD for GetCategories. >- >-=cut >- > sub GetCategories { > my ( $self, $params ) = @_; > my $selected = $params->{selected}; >@@ -122,10 +110,18 @@ Koha::Template::Plugin::AuthorisedValues - TT Plugin for authorised values > In a template, you can get the description for an authorised value with > the following TT code: [% AuthorisedValues.GetByCode( 'CATEGORY', 'AUTHORISED_VALUE_CODE', 'IS_OPAC' ) %] > >+=head2 Get >+ >+Missing POD for Get. >+ > =head2 GetAuthValueDropbox > > The parameters are identical to those used by the subroutine C4::Koha::GetAuthValueDropbox > >+=head2 GetCategories >+ >+Missing POD for GetCategories. >+ > =head2 GetDescriptionsByKohaField > > The parameters are identical to those used by the subroutine Koha::AuthorisedValues->get_descriptions_by_koha_field >diff --git a/t/lib/QA/TemplateFilters.pm b/t/lib/QA/TemplateFilters.pm >index bb0a551f635..1339ab6dd01 100644 >--- a/t/lib/QA/TemplateFilters.pm >+++ b/t/lib/QA/TemplateFilters.pm >@@ -122,12 +122,6 @@ sub _process_tt_content { > return { errors => \@errors, new_content => $new_content }; > } > >-=head2 process_tt_block >- >-Missing POD for process_tt_block. >- >-=cut >- > sub process_tt_block { > my ( $line, $params ) = @_; > my $tt_block = $params->{tt_block}; >@@ -280,6 +274,9 @@ and to not duplicate the code. > * line is the line where the error has been found. > * line_number is the line number where the error has been found. > >+=head2 process_tt_block >+ >+Missing POD for process_tt_block. > > =head1 AUTHORS > >diff --git a/t/lib/Selenium.pm b/t/lib/Selenium.pm >index ac2d13e61ce..260592bc084 100644 >--- a/t/lib/Selenium.pm >+++ b/t/lib/Selenium.pm >@@ -73,12 +73,6 @@ sub remove_error_handler { > $self->{driver}->error_handler( sub { } ); > } > >-=head2 config >- >-Missing POD for config. >- >-=cut >- > sub config { > return { > login => $ENV{KOHA_USER} || 'koha', >@@ -103,12 +97,6 @@ sub auth { > $login_button->click(); > } > >-=head2 opac_auth >- >-Missing POD for opac_auth. >- >-=cut >- > sub opac_auth { > my ( $self, $login, $password ) = @_; > >@@ -309,12 +297,6 @@ sub click_when_visible { > $elt->click unless $clicked; # finally Raise the error > } > >-=head2 max_retries >- >-Missing POD for max_retries. >- >-=cut >- > sub max_retries { 10 } > > =head1 NAME >@@ -438,6 +420,18 @@ It will remove any kinds of error raised by the driver. > It can be useful in some cases, for instance if you want to make sure something will not happen and that could make the driver exploses otherwise. > You certainly should call it for only one statement then must call add_error_handler right after. > >+=head2 config >+ >+Missing POD for config. >+ >+=head2 opac_auth >+ >+Missing POD for opac_auth. >+ >+=head2 max_retries >+ >+Missing POD for max_retries. >+ > =head1 AUTHORS > > Jonathan Druart <jonathan.druart@bugs.koha-community.org> >diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm >index 94b81b7dfb7..58ce08c5b89 100644 >--- a/t/lib/TestBuilder.pm >+++ b/t/lib/TestBuilder.pm >@@ -161,12 +161,6 @@ sub build { > ); > } > >-=head2 build_sample_biblio >- >-Missing POD for build_sample_biblio. >- >-=cut >- > sub build_sample_biblio { > my ( $self, $args ) = @_; > >@@ -198,12 +192,6 @@ sub build_sample_biblio { > return Koha::Biblios->find($biblio_id); > } > >-=head2 build_sample_item >- >-Missing POD for build_sample_item. >- >-=cut >- > sub build_sample_item { > my ( $self, $args ) = @_; > >@@ -602,12 +590,6 @@ sub _gen_text { > return $random->randregex($regex); > } > >-=head2 alt_rand >- >-Missing POD for alt_rand. >- >-=cut >- > sub alt_rand { #Alternative randomizer > my ($max) = @_; > my $random = Bytes::Random::Secure->new( NonBlocking => 1 ); >@@ -830,6 +812,14 @@ if a record with that primary key already exists. > Given a plural Koha::Object-derived class, it creates a random element, and > returns the corresponding Koha::Object. > >+=head2 build_sample_biblio >+ >+Missing POD for build_sample_biblio. >+ >+=head2 build_sample_item >+ >+Missing POD for build_sample_item. >+ > =head2 build_sample_ill_request > > my $ill_request = $builder->build_sample_ill_request({ biblio_id => $biblio_id }); >@@ -848,6 +838,10 @@ C<$args> is a hashref with the following optional keys: > > =back > >+=head2 alt_rand >+ >+Missing POD for alt_rand. >+ > =head1 AUTHOR > > Yohann Dufour <yohann.dufour@biblibre.com> >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39367
:
179451
|
179452
|
179453
|
179456
|
179457
|
179458
|
179459
|
179460
|
179544
|
179545
|
179546
|
179547
|
179548
|
179549
|
180089
|
180090
|
180091
|
180092
|
180093
|
180094
|
181238