Bugzilla – Attachment 179500 Details for
Bug 39293
Remove box around subfield tag in basic editor
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39293: Remove box around subfield tag in basic editor
Bug-39293-Remove-box-around-subfield-tag-in-basic-.patch (text/plain), 2.65 KB, created by
Baptiste Wojtkowski (bwoj)
on 2025-03-20 10:36:40 UTC
(
hide
)
Description:
Bug 39293: Remove box around subfield tag in basic editor
Filename:
MIME Type:
Creator:
Baptiste Wojtkowski (bwoj)
Created:
2025-03-20 10:36:40 UTC
Size:
2.65 KB
patch
obsolete
>From 816e4642adb317ca48c1a8d34fe1e592a6790f38 Mon Sep 17 00:00:00 2001 >From: Phil Ringnalda <phil@chetcolibrary.org> >Date: Wed, 12 Mar 2025 10:06:37 -0700 >Subject: [PATCH] Bug 39293: Remove box around subfield tag in basic editor > >Prior to the Bootstrap 5 update, the feature of editing subfield codes in the >basic editor was kept subtle by putting the code in an <input>, but removing >the border around the input, so it required either knowing the feature exists >or accidentally clicking on or around the single letter code and seeing it >turn into an editable input. > >This patch removes the border again, because when people accidentally see the >feature, they are sometimes not pleased to see it. > >Test plan: >1. Without the patch, open the cataloging basic editor and switch to the "1" > tab with the 100 fields. >2. Note that the codes for the subfields are clearly in editable inputs. >3. Apply patch, reload the editor page. >4. Note that now the codes look like just plain text, until you actually > click on or very near the letter, when they become visible as inputs > by having the focus border. > >Sponsored-by: Chetco Community Public Library >Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> >Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> >--- > .../intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >index 9fff1c91..ad4d899f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >@@ -1129,7 +1129,7 @@ > <span class="handle"></span> > <input type="text" > title="[% subfield_loo.marc_lib | $raw %]" >- style=" [% IF ( subfield_loo.fixedfield ) %]display:none; [% END %]" >+ style=" [% IF ( subfield_loo.fixedfield ) %]display:none; [% END %]border:0;" > name="tag_[% subfield_loo.tag | html %]_code_[% subfield_loo.subfield | html %]_[% subfield_loo.index | html %]_[% subfield_loo.index_subfield | html %]" > value="[% subfield_loo.subfield | html %]" > size="1" >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39293
:
179128
|
179190
|
179221
|
179231
| 179500