Bugzilla – Attachment 179532 Details for
Bug 39325
Run codespell successfully on the whole codebase
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39325: Tidy
Bug-39325-Tidy.patch (text/plain), 6.25 KB, created by
Owen Leonard
on 2025-03-20 13:13:57 UTC
(
hide
)
Description:
Bug 39325: Tidy
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-03-20 13:13:57 UTC
Size:
6.25 KB
patch
obsolete
>From 057977f2febb12c335da90834a65393e84eff83a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 20 Mar 2025 10:48:08 +0100 >Subject: [PATCH] Bug 39325: Tidy > >Some files need to be tidy after the automatic commit > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > C4/Biblio.pm | 2 +- > C4/Languages.pm | 6 +++--- > C4/SIP/ILS.pm | 2 +- > fix-perl-path.PL | 2 +- > reports/acquisitions_stats.pl | 8 ++++---- > reports/cat_issues_top.pl | 4 ++-- > reports/catalogue_stats.pl | 10 +++++----- > reports/issues_avg_stats.pl | 8 ++++---- > 8 files changed, 21 insertions(+), 21 deletions(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index 41923f1dfd2..5aac2308796 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -938,7 +938,7 @@ sub GetISBDView { > my ( $holdingbrtagf, $holdingbrtagsubf ) = &GetMarcFromKohaField("items.holdingbranch"); > my $tagslib = GetMarcStructure( 1, $itemtype, { unsafe => 1 } ); > >- my $ISBD = C4::Context->preference($sysprefname); >+ my $ISBD = C4::Context->preference($sysprefname); > my $block = $ISBD; > my $res; > my $blocres; >diff --git a/C4/Languages.pm b/C4/Languages.pm >index 554422c86d5..c4c03d48f7b 100644 >--- a/C4/Languages.pm >+++ b/C4/Languages.pm >@@ -421,10 +421,10 @@ sub _build_languages_arrayref { > > my %idx = map { $enabled_languages->[$_] => $_ } reverse 0 .. @$enabled_languages - 1; > my @ordered_keys = sort { >- my $aa = ''; >- my $bb = ''; >+ my $aa = ''; >+ my $bb = ''; > my $account = @{ $language_groups->{$a} }; >- my $bcount = @{ $language_groups->{$b} }; >+ my $bcount = @{ $language_groups->{$b} }; > if ( $language_groups->{$a}->[0]->{enabled} ) { > $aa = $language_groups->{$a}->[0]->{rfc4646_subtag}; > } elsif ( $account > 1 ) { >diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm >index 9c853dc87de..d805e4efcb7 100644 >--- a/C4/SIP/ILS.pm >+++ b/C4/SIP/ILS.pm >@@ -1019,7 +1019,7 @@ take. > > =item C<$fee_ack> > >-Boolean. If true, the patron has acknowleged that she is willing >+Boolean. If true, the patron has acknowledged that she is willing > to pay the fee associated with placing a hold on this item. If > C<$fee_ack> is false, then the ILS should refuse to place the > hold. >diff --git a/fix-perl-path.PL b/fix-perl-path.PL >index 839b4390b29..43be7f7a43e 100644 >--- a/fix-perl-path.PL >+++ b/fix-perl-path.PL >@@ -28,7 +28,7 @@ my $bindir = $Config{installbin}; > $bindir =~ s!\\!/!g; # make all directory separators uniform since Win32 does not care and *nix does... > my $shebang = "#!$bindir\/perl"; > >-warn "Perl binary located in $bindir on this system.\n" if $DEBUG; >+warn "Perl binary located in $bindir on this system.\n" if $DEBUG; > warn "The shebang line for this systems should be $shebang\n\n" if $DEBUG; > > die if $basedir eq 'test'; >diff --git a/reports/acquisitions_stats.pl b/reports/acquisitions_stats.pl >index 6dd73cfad66..4457e56f244 100755 >--- a/reports/acquisitions_stats.pl >+++ b/reports/acquisitions_stats.pl >@@ -379,7 +379,7 @@ sub calculate { > } > } > >- my $i = 0; >+ my $i = 0; > my $highlighted = -1; > > #Initialization of cell values..... >@@ -478,10 +478,10 @@ sub calculate { > push @loopcell, { value => $value }; > } > my $r = { >- rowtitle => ( $row eq "zzEMPTY" ) ? "NULL" : $row, >- loopcell => \@loopcell, >+ rowtitle => ( $row eq "zzEMPTY" ) ? "NULL" : $row, >+ loopcell => \@loopcell, > highlighted => ( $highlighted > 0 ), >- totalrow => $table{$row}->{totalrow} >+ totalrow => $table{$row}->{totalrow} > }; > $r->{totalrow} = sprintf( "%.2f", $r->{totalrow} ) if ( $r->{totalrow} and grep /$process/, ( 3, 4, 5 ) ); > push @looprow, $r; >diff --git a/reports/cat_issues_top.pl b/reports/cat_issues_top.pl >index 35ff98e975b..1bf6b337fa3 100755 >--- a/reports/cat_issues_top.pl >+++ b/reports/cat_issues_top.pl >@@ -406,8 +406,8 @@ sub calculate { > > #my $total = $table[$i]->{totalrow}/$colcount if ($colcount>0); > push @looprow, { >- 'rowtitle' => $i, >- 'loopcell' => \@loopcell, >+ 'rowtitle' => $i, >+ 'loopcell' => \@loopcell, > 'highlighted' => ( $highlighted > 0 ), > }; > $highlighted = -$highlighted; >diff --git a/reports/catalogue_stats.pl b/reports/catalogue_stats.pl >index facc0d782d5..aca5b4bc2c6 100755 >--- a/reports/catalogue_stats.pl >+++ b/reports/catalogue_stats.pl >@@ -401,7 +401,7 @@ sub calculate { > push @loopcol, \%cell; > } > >- my $i = 0; >+ my $i = 0; > my $highlighted = -1; > > #Initialization of cell values..... >@@ -540,11 +540,11 @@ sub calculate { > } > push @looprow, > { >- 'rowtitle' => $row->{rowtitle}, >- 'value' => $row->{value}, >- 'loopcell' => \@loopcell, >+ 'rowtitle' => $row->{rowtitle}, >+ 'value' => $row->{value}, >+ 'loopcell' => \@loopcell, > 'highlighted' => ( $highlighted *= -1 > 0 ), >- 'totalrow' => $table{ $row->{value} }->{totalrow} >+ 'totalrow' => $table{ $row->{value} }->{totalrow} > }; > } > >diff --git a/reports/issues_avg_stats.pl b/reports/issues_avg_stats.pl >index f4db4986f2b..ae376f3cde0 100755 >--- a/reports/issues_avg_stats.pl >+++ b/reports/issues_avg_stats.pl >@@ -386,7 +386,7 @@ sub calculate { > > # warn "fin des titres colonnes"; > >- my $i = 0; >+ my $i = 0; > my $highlighted = -1; > > #Initialization of cell values..... >@@ -515,10 +515,10 @@ sub calculate { > } > push @looprow, > { >- 'rowtitle' => ( $row eq "zzEMPTY" ) ? "NULL" : $row, >- 'loopcell' => \@loopcell, >+ 'rowtitle' => ( $row eq "zzEMPTY" ) ? "NULL" : $row, >+ 'loopcell' => \@loopcell, > 'highlighted' => ( $highlighted > 0 ), >- 'totalrow' => ($total) ? sprintf( "%.2f", $total ) : 0 >+ 'totalrow' => ($total) ? sprintf( "%.2f", $total ) : 0 > }; > $highlighted = -$highlighted; > } >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39325
:
179269
|
179270
|
179271
|
179272
|
179501
|
179502
|
179503
|
179504
|
179505
|
179506
|
179507
|
179508
|
179509
|
179510
|
179511
|
179512
|
179517
|
179518
|
179519
|
179522
|
179525
|
179527
|
179528
|
179529
|
179530
|
179531
|
179532
|
179533
|
179534
|
180137
|
180138
|
180139
|
180140
|
180141
|
180142
|
180143
|
180144
|
180145
|
180146
|
180147
|
180148
|
180149
|
180150
|
181510
|
181511
|
181512
|
181513
|
181514
|
181515
|
181516
|
181517
|
181518
|
181519
|
181520
|
181521
|
181522
|
181523
|
181611
|
181612
|
181613
|
181614
|
181615
|
181616
|
181617
|
181618
|
181619
|
181620
|
181621
|
181637
|
181651
|
181983