Bugzilla – Attachment 179539 Details for
Bug 38842
Refactor modal logic in returns.tt / returns.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38842: Add block to DRY out checkin page pass-through data
Bug-38842-Add-block-to-DRY-out-checkin-page-pass-t.patch (text/plain), 2.35 KB, created by
Baptiste Wojtkowski (bwoj)
on 2025-03-20 15:23:00 UTC
(
hide
)
Description:
Bug 38842: Add block to DRY out checkin page pass-through data
Filename:
MIME Type:
Creator:
Baptiste Wojtkowski (bwoj)
Created:
2025-03-20 15:23:00 UTC
Size:
2.35 KB
patch
obsolete
>From 3471cd6408c4328b432020358b7d697dcb0af62d Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Fri, 7 Mar 2025 08:26:17 -0500 >Subject: [PATCH] Bug 38842: Add block to DRY out checkin page pass-through > data > >There are a number of variable values that need to get passed back to >the controller after submitting a modal to maintain the checkin page's >state. Currently, all of these inputs are manually coded for each modal. >Add a Template Toolkit block that can be used instead to add all of >these mandatory "pass-through" values. > >Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> >--- > .../prog/en/modules/circ/returns.tt | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index d2b1f676..6552e8c4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -1479,6 +1479,22 @@ > [% INCLUDE 'modals/add_catalog_concern.inc' %] > [% END %] > >+[%# passthrough_data: adds hidden inputs for any data that needs to be preserved and passed back to the controller after a modal response %] >+[% BLOCK passthrough_data %] >+ <fieldset id="checkin_passthrough"> >+ <input type="hidden" name="return_date_override" value="[% return_date_override | html %]" /> >+ <input type="hidden" name="return_date_override_remember" value="[% return_date_override_remember | html %]" /> >+ <input type="hidden" name="dropboxmode" value="[% dropboxmode | html %]" /> >+ <input type="hidden" name="exemptfine" value="[% exemptfine | html %]" /> >+ [% FOREACH inputloo IN inputloop %] >+ <input type="hidden" name="ri-[% inputloo.counter | html %]" value="[% inputloo.barcode | html %]" /> >+ <input type="hidden" name="dd-[% inputloo.counter | html %]" value="[% inputloo.duedate | html %]" /> >+ <input type="hidden" name="bn-[% inputloo.counter | html %]" value="[% inputloo.borrowernumber | html %]" /> >+ <input type="hidden" name="nr-[% inputloo.counter | html %]" value="[% inputloo.not_returned | html %]" /> >+ [% END %] >+ </fieldset> >+[% END %] >+ > [% MACRO jsinclude BLOCK %] > [% INCLUDE 'datatables.inc' %] > [% INCLUDE 'calendar.inc' %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38842
:
178875
|
179084
|
179085
|
179086
|
179087
|
179127
|
179520
|
179521
|
179523
|
179524
|
179526
|
179538
|
179539
|
179540
|
179541
|
179542
|
180752
|
180753
|
180754
|
180755
|
180756