Bugzilla – Attachment 179610 Details for
Bug 39397
Searching a biblio by timestamp returns a different timestamp
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39397: 'biblio' attributes take precedence over 'biblioitems' in response
Bug-39397-biblio-attributes-take-precedence-over-b.patch (text/plain), 1.18 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-03-21 13:56:21 UTC
(
hide
)
Description:
Bug 39397: 'biblio' attributes take precedence over 'biblioitems' in response
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-03-21 13:56:21 UTC
Size:
1.18 KB
patch
obsolete
>From 74c4aba396249f49942ae22497c74c8ce7e872c6 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 21 Mar 2025 10:52:45 -0300 >Subject: [PATCH] Bug 39397: 'biblio' attributes take precedence over > 'biblioitems' in response > >This patch swaps biblio for biblioitem attributes in the return value. >The effect is that attributes from the `biblio` table overwrite those >named the same (`timestamp` being the target). > >To test: >1. Apply the regression tests patch >2. Run: > $ ktd --shell > k$ prove t/db_dependent/api/v1/biblios.t >=> FAIL: The biblioitems.timestamp is returned! >3. Apply this patch >4. Repeat 2 >=> SUCCESS: Things go smooth now >5. Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Biblio.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm >index e3971b1cb55..d735243c56f 100644 >--- a/Koha/Biblio.pm >+++ b/Koha/Biblio.pm >@@ -1735,7 +1735,7 @@ sub to_api { > my $json_biblioitem = $biblioitem->to_api($args); > return unless $json_biblioitem; > >- return { %$json_biblio, %$json_biblioitem }; >+ return { %$json_biblioitem, %$json_biblio }; > } > > =head3 to_api_mapping >-- >2.49.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39397
:
179609
|
179610
|
180097
|
180098
|
180398
|
180399