Bugzilla – Attachment 179632 Details for
Bug 39361
Hold found modal does not display from circulation / transfer
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39361: Wrap modal JS in document ready function
Bug-39361-Wrap-modal-JS-in-document-ready-function.patch (text/plain), 1.46 KB, created by
Nick Clemens (kidclamp)
on 2025-03-23 16:33:54 UTC
(
hide
)
Description:
Bug 39361: Wrap modal JS in document ready function
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2025-03-23 16:33:54 UTC
Size:
1.46 KB
patch
obsolete
>From 69ab1b476179c0ddbb3b263d7d7d0eb8422e7a8d Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 17 Mar 2025 15:08:23 +0000 >Subject: [PATCH] Bug 39361: Wrap modal JS in document ready function > >To test: >1. Find or create an item with a hold on it. >2. Go to Circulation > Transfers >3. Transfer the item from step 1. >4. No modal appears to warn that the item has a hold. >5. APPLY PATCH >6. Try step 3 again, this time the modal should appear correctly. > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > .../intranet-tmpl/prog/en/modules/circ/branchtransfers.tt | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >index 4a9a7d5b3ce..56dd9901695 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >@@ -301,9 +301,11 @@ > var to_branch = $(this).attr('data-tobranch'); > window.open("/cgi-bin/koha/circ/transfer-slip.pl?transferitem=" + itemnumber + "&branchcode=" + to_branch); > }); >- [% IF ( found ) %] >- $("#transfer_confirm").modal("show"); >- [% END %] >+ $(document).ready( function() { >+ [% IF ( found ) %] >+ $("#transfer_confirm").modal('show'); >+ [% END %] >+ }); > </script> > [% END %] > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39361
:
179395
|
179632
|
179799