Bugzilla – Attachment 179637 Details for
Bug 39409
Duplicate modifybiblio ids in cataloguing toolbar
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39409: Duplicate modifybiblio ids in cat-toolbar
Bug-39409-Duplicate-modifybiblio-ids-in-cat-toolba.patch (text/plain), 2.52 KB, created by
Jonathan Druart
on 2025-03-24 10:06:08 UTC
(
hide
)
Description:
Bug 39409: Duplicate modifybiblio ids in cat-toolbar
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-03-24 10:06:08 UTC
Size:
2.52 KB
patch
obsolete
>From 6ac49b6cd0ccf6b87b660ffd3832ddb7cfab358a Mon Sep 17 00:00:00 2001 >From: Phil Ringnalda <phil@chetcolibrary.org> >Date: Fri, 21 Mar 2025 07:16:42 -0700 >Subject: [PATCH] Bug 39409: Duplicate modifybiblio ids in cat-toolbar > >The biblio details page Edit menu has three different elements which all >have id="modifybibilio", two of which also have another id. Neither of those >things is allowed. > >Test plan: >1. Without the patch, load the details view for any biblio record and View > source >2. Search for id="modifybiblio" >3. You will get three results, the second and third shown with id in red >4. Apply patch, reload the page, View source and search again >5. You will get one result, without any red > >Sponsored-by: Chetco Community Public Library > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >index 2b033e40f6a..f760ebc8117 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >@@ -70,7 +70,7 @@ > <input type="hidden" name="op" value="cud-show" /> > <input type="hidden" name="biblionumber" value="[% biblionumber | html %]" /> > <input type="hidden" name="src" value="CATALOGUING" /> >- <button id="batchedit" type="submit" class="dropdown-item" id="modifybiblio">Edit items in a batch</button> >+ <button id="batchedit" type="submit" class="dropdown-item">Edit items in a batch</button> > </form> > </li> > [% ELSE %] >@@ -89,7 +89,7 @@ > <input type="hidden" name="del" value="1" /> > <input type="hidden" name="biblionumber" value="[% biblionumber | html %]" /> > <input type="hidden" name="src" value="CATALOGUING" /> >- <button id="batchdelete" type="submit" class="dropdown-item" id="modifybiblio">Delete items in a batch</button> >+ <button id="batchdelete" type="submit" class="dropdown-item">Delete items in a batch</button> > </form> > </li> > [% ELSE %] >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39409
:
179616
| 179637