Bugzilla – Attachment 179670 Details for
Bug 17338
'Holds awaiting pickup' should keep you on the same tab when cancelling a hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17338: Fix anchor to redirect properly when canceling holds over X
Bug-17338-Fix-anchor-to-redirect-properly-when-can.patch (text/plain), 2.20 KB, created by
Lucas Gass (lukeg)
on 2025-03-24 18:27:33 UTC
(
hide
)
Description:
Bug 17338: Fix anchor to redirect properly when canceling holds over X
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-03-24 18:27:33 UTC
Size:
2.20 KB
patch
obsolete
>From d38cf6bc4b557d54361f12a155a5a9f554705e0b Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 24 Mar 2025 18:24:48 +0000 >Subject: [PATCH] Bug 17338: Fix anchor to redirect properly when canceling > holds over X > >To test: >1. Place multiple holds, good to have at least 4, for pickup at a location, I used Nick's handy script >2. Perl misc/cronjobs/holds/build_holds_queue.pl >3. Check in at least 4 items for pickup at one location so they'll be wating >4. Update the expiration date on those holds using ktd --dbshell > update reserves set expirationdate = DATE('2024-01-01') where branchcode='CPL'; >5. On Circulation > Holds waiting past their expiration date tab use the cancel button that is in the actions column to cancel a hold > >The page loads on the Holds waiting tab, although in the url you see /circ/waitingreserves.pl#holdsover > >6. APPLY PATCH >7. Try 1 - 5 again, this time after step 5 you should be redirected. >--- > koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >index ef43953e306..41bd9a3a09e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >@@ -74,7 +74,7 @@ > <input type="hidden" name="itemnumber" value="[% reserveloo.item.itemnumber | html %]" /> > <input type="hidden" name="fbr" value="[% reserveloo.item.holdingbranch | html %]" /> > <input type="hidden" name="tbr" value="[% reserveloo.item.homebranch | html %]" /> >- <input type="hidden" name="tab" value="[% tab | html %]" /> >+ <input type="hidden" name="tab" value="[% tab | html %]_panel" /> > [% IF ( reserveloo.item.homebranch != reserveloo.item.holdingbranch ) %] > <button type="submit" class="btn btn-default btn-xs"><i class="fa fa-times"></i> Cancel hold and return to: [% Branches.GetName( reserveloo.item.homebranch ) | html %]</button> > [% ELSE %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17338
:
179670
|
180203
|
181631
|
181830