Bugzilla – Attachment 179720 Details for
Bug 35604
ILL - Allow for automatic backend selection
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35604: (QA follow-up): Remove occurrences of 'auto' and 'automatic'
Bug-35604-QA-follow-up-Remove-occurrences-of-auto-.patch (text/plain), 4.47 KB, created by
Pedro Amorim
on 2025-03-26 10:16:09 UTC
(
hide
)
Description:
Bug 35604: (QA follow-up): Remove occurrences of 'auto' and 'automatic'
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-03-26 10:16:09 UTC
Size:
4.47 KB
patch
obsolete
>From 451e853c65aaaf776f65cdd5afa1df43bb4d4483 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Wed, 26 Mar 2025 10:13:54 +0000 >Subject: [PATCH] Bug 35604: (QA follow-up): Remove occurrences of 'auto' and > 'automatic' > >User testing reported that making a UI distinction between 'regular' and 'automatic' ILL requests is redundant. >This patch reverts it. >--- > Koha/ILL/Backend/intra-includes/create.inc | 6 +----- > Koha/ILL/Backend/opac-includes/create.inc | 6 +----- > koha-tmpl/intranet-tmpl/prog/en/includes/ill-toolbar.inc | 2 +- > .../opac-tmpl/bootstrap/en/modules/opac-illrequests.tt | 2 +- > 4 files changed, 4 insertions(+), 12 deletions(-) > >diff --git a/Koha/ILL/Backend/intra-includes/create.inc b/Koha/ILL/Backend/intra-includes/create.inc >index 00ed751e05b..7f45536d487 100644 >--- a/Koha/ILL/Backend/intra-includes/create.inc >+++ b/Koha/ILL/Backend/intra-includes/create.inc >@@ -17,11 +17,7 @@ > [% END %] > > [% IF whole.stage == "form" %] >-[% IF Koha.Preference('AutoILLBackendPriority') %] >- <h2>Create an automatic ILL request</h2> >-[% ELSE %] >- <h2>Create a manual ILL request</h2> >-[% END %] >+<h2>Create an ILL request</h2> > <form id="create_form" method="POST" action=""> > [% INCLUDE 'csrf-token.inc' %] > <fieldset class="rows"> >diff --git a/Koha/ILL/Backend/opac-includes/create.inc b/Koha/ILL/Backend/opac-includes/create.inc >index 72c137c9cc4..1b14f8dd02b 100644 >--- a/Koha/ILL/Backend/opac-includes/create.inc >+++ b/Koha/ILL/Backend/opac-includes/create.inc >@@ -30,11 +30,7 @@ > [% SET opac = whole.value.other.opac %] > > [% IF whole.stage == "form" %] >-[% IF Koha.Preference('AutoILLBackendPriority') %] >- <h2>Create an automatic ILL request</h2> >-[% ELSE %] >- <h2>Create a manual ILL request</h2> >-[% END %] >+<h2>Create an ILL request</h2> > <form id="create_form" method="POST" action=""> > [% INCLUDE 'csrf-token.inc' %] > <fieldset class="rows"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-toolbar.inc >index acf59c9ad8d..1c85da4f629 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-toolbar.inc >@@ -3,7 +3,7 @@ > <div id="toolbar" class="btn-toolbar ill-toolbar"> > [% IF backends_available %] > [% IF Koha.Preference('AutoILLBackendPriority') %] >- <a id="ill-new" class="btn btn-default" href="/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard"> <i class="fa fa-plus"></i> New auto ILL request </a> >+ <a id="ill-new" class="btn btn-default" href="/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard"> <i class="fa fa-plus"></i> New ILL request </a> > [% ELSIF backends.size > 1 %] > <div class="dropdown btn-group"> > <button class="btn btn-default dropdown-toggle" type="button" id="ill-backend-dropdown" data-bs-toggle="dropdown" aria-haspopup="true" aria-expanded="true"> <i class="fa fa-plus"></i> New ILL request </button> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >index 943e63c480e..313fac007b6 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >@@ -118,7 +118,7 @@ > [% IF can_patron_place_ill_in_opac %] > <div id="illrequests-create-button" class="dropdown btn-group"> > [% IF Koha.Preference('AutoILLBackendPriority') %] >- <a id="ill-new" class="btn btn-primary" href="/cgi-bin/koha/opac-illrequests.pl?method=create&backend=Standard"> <i class="fa fa-plus" aria-hidden="true"></i> Create a new auto request </a> >+ <a id="ill-new" class="btn btn-primary" href="/cgi-bin/koha/opac-illrequests.pl?method=create&backend=Standard"> <i class="fa fa-plus" aria-hidden="true"></i> Create a new request </a> > [% ELSIF backends.size > 1 %] > <button class="btn btn-primary dropdown-toggle" type="button" id="ill-backend-dropdown" data-bs-toggle="dropdown" aria-haspopup="true" aria-expanded="true"> > <i class="fa fa-plus" aria-hidden="true"></i> Create a new request <span class="caret"></span> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35604
:
160035
|
164883
|
164884
|
164885
|
164886
|
164887
|
164888
|
165135
|
165164
|
165165
|
165294
|
165295
|
165296
|
165297
|
165298
|
165299
|
165300
|
166897
|
166898
|
166899
|
166900
|
166901
|
166902
|
166903
|
166995
|
166996
|
166997
|
166998
|
166999
|
167000
|
167001
|
171326
|
171327
|
171328
|
171329
|
171330
|
171331
|
171332
|
174515
|
174516
|
174517
|
174518
|
174519
|
174520
|
174521
|
174522
|
174524
|
174792
|
175828
|
175829
|
175830
|
175831
|
175832
|
175833
|
175834
|
175835
|
175836
|
176036
|
176261
|
176262
|
176263
|
176264
|
176265
|
176266
|
176267
|
176268
|
176269
|
176270
|
176572
|
176662
|
176681
|
176682
|
176683
|
176684
|
176685
|
176686
|
176687
|
176688
|
176689
|
176690
|
176691
|
176692
|
178305
|
178306
|
178307
|
178308
|
178309
|
178310
|
178311
|
178312
|
178313
|
178314
|
178315
|
178316
|
178707
|
178708
|
178709
|
178710
|
178711
|
178712
|
178713
|
178714
|
178715
|
178716
|
178717
|
178718
|
179698
|
179699
|
179720
|
179721
|
180335
|
180451
|
180452
|
180453
|
180454
|
180455
|
180456
|
180457
|
180458
|
180459
|
180460
|
180461
|
180462
|
180463
|
180464
|
180465
|
180956