Bugzilla – Attachment 179725 Details for
Bug 39449
OPAC table sort arrows show opposite sort direction
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39449: Fix table sort arrows
Bug-39449-Fix-table-sort-arrows.patch (text/plain), 2.57 KB, created by
Owen Leonard
on 2025-03-26 11:15:01 UTC
(
hide
)
Description:
Bug 39449: Fix table sort arrows
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-03-26 11:15:01 UTC
Size:
2.57 KB
patch
obsolete
>From bf8f5406abd3ee5e50e415c5d225285f1a0bfd0c Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Tue, 25 Mar 2025 15:41:08 +0000 >Subject: [PATCH] Bug 39449: Fix table sort arrows > >Test plan: >1) Look at the same biblio on both OPAC and Staff: >http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 >http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=76 > >2) Click on the 'current library' column header for OPAC and 'Home > library' for staff. Notice that on Staff when it's DESC, arrow points > down (as expected), but on OPAC when it's DESC, the arrows points up. > >3) Apply patch. Reset CSS: > yarn css:build > >4) Do a hard refresh on the OPAC. Repeat test plan. Notice they now > behave the same. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../opac-tmpl/bootstrap/css/src/_common.scss | 18 ++++++------------ > 1 file changed, 6 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss >index 0f9516bd00f..b290d8c7880 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss >+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss >@@ -579,12 +579,6 @@ table { > line-height: .5rem; > } > >- &.dt-ordering-asc span.dt-column-order::before >- &.dt-ordering-desc span.dt-column-order::after { >- color: #006100; >- opacity: 1; >- } >- > &.dt-orderable-asc span.dt-column-order::before, > &.dt-ordering-asc span.dt-column-order::before { > content: "\f0d8"; /* fa-cart-up */ >@@ -619,12 +613,6 @@ table { > } > } > >- >- &.dt-ordering-asc span.dt-column-order::after, >- &.dt-ordering-desc span.dt-column-order::before { >- opacity: 1; >- } >- > &.dt-ordering-asc span.dt-column-order::before, > &.dt-ordering-desc span.dt-column-order::after { > opacity: .2; >@@ -638,6 +626,12 @@ table { > &:active { > outline: none; > } >+ >+ &.dt-ordering-asc span.dt-column-order::before, >+ &.dt-ordering-desc span.dt-column-order::after { >+ color: #006100; >+ opacity: 1; >+ } > } > } > } >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39449
:
179686
|
179725
|
180055