Bugzilla – Attachment 17974 Details for
Bug 10185
updatedatabase.pl remove all reserves
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10185: Fix update 3.09.00.025
PASSED-QA-Bug-10185-Fix-update-30900025.patch (text/plain), 1.48 KB, created by
Katrin Fischer
on 2013-05-07 06:48:31 UTC
(
hide
)
Description:
[PASSED QA] Bug 10185: Fix update 3.09.00.025
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-05-07 06:48:31 UTC
Size:
1.48 KB
patch
obsolete
>From 5f18b7e7291e72f5ecb3f13be5ce5b3094b5aa63 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Fri, 3 May 2013 17:20:17 +0200 >Subject: [PATCH] [PASSED QA] Bug 10185: Fix update 3.09.00.025 > >It can remove all reserves from reserves table when there is no entries >in old_reserves. >This is due to @ai which is set to NULL in > SET @ai = ( SELECT MAX( reserve_id ) FROM tmp_reserves ) >and reserve_id > NULL returns no results in > INSERT INTO reserves SELECT * FROM tmp_reserves WHERE reserve_id > @ai > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Test plan and comments on second patch. >--- > installer/data/mysql/updatedatabase.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 2c1f1f4..d1f857f 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -5516,7 +5516,7 @@ if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { > "); > $dbh->do('TRUNCATE reserves'); > $dbh->do('ALTER TABLE reserves ADD reserve_id INT( 11 ) NOT NULL AUTO_INCREMENT PRIMARY KEY FIRST'); >- $dbh->do('INSERT INTO reserves SELECT * FROM tmp_reserves WHERE reserve_id > @ai'); >+ $dbh->do('INSERT INTO reserves SELECT * FROM tmp_reserves WHERE reserve_id > COALESCE(@ai, 0)'); > $dbh->do('DROP TABLE tmp_reserves'); > $dbh->do('COMMIT'); > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10185
:
17934
|
17939
|
17958
|
17973
| 17974 |
17975