Bugzilla – Attachment 179771 Details for
Bug 36197
Allow unauthenticated ILL requests in the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36197: Update how the request is added:
Bug-36197-Update-how-the-request-is-added.patch (text/plain), 2.43 KB, created by
Pedro Amorim
on 2025-03-27 12:17:26 UTC
(
hide
)
Description:
Bug 36197: Update how the request is added:
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-03-27 12:17:26 UTC
Size:
2.43 KB
patch
obsolete
>From 33b837be5cf165b578746c0872ea56c9aff00370 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Tue, 5 Mar 2024 17:04:57 +0000 >Subject: [PATCH] Bug 36197: Update how the request is added: > >- Do not validate borrower if its an unauthenticated request >- Set borrowernumber to null if its an unauthenticated request >- Add staff and OPAC notes with unauthenticated request info > >Signed-off-by: David Nind <david@davidnind.com> >--- > Koha/ILL/Backend/Standard.pm | 17 ++++++++++++++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > >diff --git a/Koha/ILL/Backend/Standard.pm b/Koha/ILL/Backend/Standard.pm >index 22f489a2c1a..86cf029e1a7 100644 >--- a/Koha/ILL/Backend/Standard.pm >+++ b/Koha/ILL/Backend/Standard.pm >@@ -979,12 +979,14 @@ sub add_request { > > my ( $self, $params ) = @_; > >+ my $unauthenticated_request = >+ C4::Context->preference("ILLOpacUnauthenticatedRequest") && !$params->{other}->{'cardnumber'}; >+ > # ...Populate Illrequestattributes > # generate $request_details > my $request_details = _get_request_details( $params, $params->{other} ); > >- my ( $brw_count, $brw ) = >- _validate_borrower( $params->{other}->{'cardnumber'} ); >+ my ( $brw_count, $brw ) = _validate_borrower( $params->{other}->{'cardnumber'} ) unless $unauthenticated_request; > > ## Create request > >@@ -994,7 +996,7 @@ sub add_request { > # ...Populate Illrequest > my $request = $params->{request}; > $request->biblio_id($biblionumber) unless $biblionumber == 0; >- $request->borrowernumber( $brw->borrowernumber ); >+ $request->borrowernumber( $brw ? $brw->borrowernumber : undef ); > $request->branchcode( $params->{other}->{branchcode} ); > $request->status( $unauthenticated_request ? 'UNAUTH' : 'NEW' ); > $request->backend( $params->{other}->{backend} ); >@@ -1013,6 +1015,15 @@ sub add_request { > } keys %{$request_details}; > $request->extended_attributes( \@request_details_array ); > >+ if ($unauthenticated_request) { >+ my $unauthenticated_notes_text = >+ "Unauthenticated request.\nFirst name: $params->{other}->{'unauthenticated_first_name'}" >+ . ".\nLast name: $params->{other}->{'unauthenticated_last_name'}." >+ . "\nEmail: $params->{other}->{'unauthenticated_email'}."; >+ $request->append_to_note($unauthenticated_notes_text); >+ $request->notesopac($unauthenticated_notes_text)->store; >+ } >+ > return $request; > } > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36197
:
171358
|
171359
|
171360
|
171361
|
171362
|
171363
|
171364
|
171365
|
171366
|
171367
|
171368
|
171369
|
171370
|
171371
|
174495
|
174496
|
174497
|
174498
|
174499
|
174500
|
174501
|
174502
|
174503
|
174504
|
174505
|
174506
|
174507
|
174508
|
176564
|
176565
|
176680
|
176723
|
176724
|
176726
|
176727
|
179764
|
179765
|
179766
|
179767
|
179769
|
179770
|
179771
|
179772
|
179773
|
179774
|
179775
|
179776
|
179777
|
179778
|
179779
|
179780
|
179781
|
179782
|
179783
|
179784
|
179785
|
180850
|
180851
|
180852
|
180853
|
180854
|
180855
|
180856
|
180857
|
180858
|
180859
|
180860
|
180861
|
180862
|
180863
|
180864
|
180865
|
180866
|
180867
|
180868
|
180869
|
180870
|
180871
|
180872
|
180873
|
181073
|
181074
|
181075
|
181076
|
181077
|
181078
|
181079
|
181080
|
181081
|
181082
|
181083
|
181084
|
181085
|
181086
|
181087
|
181088
|
181089
|
181090
|
181091
|
181092
|
181093
|
181094
|
181095
|
181096
|
181097
|
181098
|
181592