Bugzilla – Attachment 179845 Details for
Bug 31736
Context for translation: "All"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31736: Editing 'All' to 'All libraries'
Bug-31736-Editing-All-to-All-libraries.patch (text/plain), 17.17 KB, created by
Hammat wele
on 2025-03-28 18:21:42 UTC
(
hide
)
Description:
Bug 31736: Editing 'All' to 'All libraries'
Filename:
MIME Type:
Creator:
Hammat wele
Created:
2025-03-28 18:21:42 UTC
Size:
17.17 KB
patch
obsolete
>From 323964e11f3e2ad9048d37add5c0275241027251 Mon Sep 17 00:00:00 2001 >From: Hammat Wele <hammat.wele@inlibro.com> >Date: Mon, 25 Mar 2024 16:16:55 +0000 >Subject: [PATCH] Bug 31736: Editing 'All' to 'All libraries' > >This patch edit the term 'All' to 'All libraries/branches', beacause All can have different genders depending on the used language ( in french All could mean 'tous for 'male-gendered' things and 'toutes' for 'female-gendered' things). > >1. Apply patch > >2. View the following pages > --> The pages work (no errors) > --> 'All' should be replace by 'All libraries/branches' > --> No spelling errors in 'All' libraries > > - Acquisitions > Invoices (Library filter on the left) > - Circulation > Holds queue (Library filter) > - Reports > Cash register (Transaction library filter) > - Reports > Items lost (Library filter) > - Serials > Check expiration (Library filter) > - Serials > Search settings icon in the search bar > Advanced search (Library filter) > - Acquisitions > Add to basket > From a subscription (Library filter on the left) > - Installer > Onboarding > New circulation rule (Library) >--- > .../prog/en/includes/serials-advsearch.inc | 2 +- > .../prog/en/includes/subscriptions-search.inc | 2 +- > .../prog/en/modules/acqui/invoices.tt | 2 +- > .../prog/en/modules/circ/view_holdsqueue.tt | 2 +- > .../en/modules/onboarding/onboardingstep5.tt | 117 +++++++++++++++++- > .../en/modules/reports/cash_register_stats.tt | 2 +- > .../prog/en/modules/reports/itemslost.tt | 2 +- > .../en/modules/serials/checkexpiration.tt | 2 +- > 8 files changed, 123 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-advsearch.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-advsearch.inc >index ac1c51e629..7644fe853d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-advsearch.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-advsearch.inc >@@ -35,7 +35,7 @@ > <li class="local"> > <label for="branch">Library:</label> > <select id="branch" name="branch_filter"> >- <option value="">All</option> >+ <option value="">All libraries/branches</option> > [%# FIXME Should not we filter the libraries? %] > [% PROCESS options_for_libraries libraries => Branches.all( selected => branch_filter, unfiltered => 1 ) %] > </select> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc >index df7379f9ee..ace5b2ca9f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc >@@ -30,7 +30,7 @@ > <li> > <label for="branch">Library:</label> > <select id="branch" name="branch_filter"> >- <option value="">All</option> >+ <option value="">>All libraries/branches</option> > [%# FIXME Should not we filter the libraries? %] > [% PROCESS options_for_libraries libraries => Branches.all( selected => branch_filter, unfiltered => 1 ) %] > </select> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt >index fb00c76613..1b817a6315 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt >@@ -430,7 +430,7 @@ > <li> > <label for="branch">Library:</label> > <select id="branch" name="branch"> >- <option value="">All</option> >+ <option value="">All libraries/branches</option> > [%# FIXME Should not we filter the libraries %] > [% PROCESS options_for_libraries libraries => Branches.all( selected => branch, unfiltered => 1 ) %] > </select> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >index 76b457569f..89ddb37c01 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >@@ -310,7 +310,7 @@ > <label for="branchlimit">Library: </label> > <select name="branchlimit" id="branchlimit"> > [% IF CAN_user_superlibrarian || !Koha.Preference('IndependentBranches') %] >- <option value="">All</option> >+ <option value="">All libraries/branches</option> > [% END %] > [% PROCESS options_for_libraries libraries => Branches.all( selected => branchlimit, only_from_group => 1 ) %] > </select> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt >index 114e03a1bc..267ba682d8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt >@@ -64,7 +64,7 @@ > <label for="branchname" class="required"> Library branch</label> > <select name="branch" id="branchname" required="required"> > <option value=""> Choose</option> >- <option value="*" selected="selected">All</option> >+ <option value="*" selected="selected">All libraries/branches</option> > [% FOREACH library IN libraries %] > <option value="[% library.branchcode | html %]"> [% library.branchname | html %]</option> > [% END %] >@@ -142,10 +142,125 @@ > <input type="text" inputmode="numeric" pattern="[0-9]*" name="reservesallowed" id="reservesallowed" size="10" value="10" /> > </li> > >+<<<<<<< HEAD > <li> > <label for="holds_per_day">Holds allowed (daily): </label> > <input type="text" inputmode="numeric" pattern="[0-9]*" name="holds_per_day" id="holds_per_day" size="10" value="10" /> > </li> >+======= >+ <form name="createcirculationrule" method="post" action="onboarding.pl"> >+ [% INCLUDE 'csrf-token.inc' %] >+ <fieldset class="rows"> >+ <input type="hidden" name="step" value="5"/> >+ <input type="hidden" name="op" value="cud-add_validate_circ_rule" /> >+ <ol> >+ <li> >+ <label for="branchname" class="required"> Library branch</label> >+ <select name="branch" id="branchname" required="required"> >+ <option value=""> Choose</option> >+ <option value="*" selected="selected">All libraries/branches</option> >+ [% FOREACH library IN libraries %] >+ <option value="[% library.branchcode | html %]"> [% library.branchname | html %]</option> >+ [% END %] >+ </select> >+ <span class="required">Required</span> >+ </li> >+ <li> >+ <label for="categorycode" class="required">Patron category: </label> >+ <select name="categorycode" id="categorycode" required="required"> >+ <option value=""> Choose</option> >+ <option value="*" selected="selected">All</option> >+ [% FOREACH category IN categories %] >+ <option value = "[% category.categorycode | html %]"> [% category.description | html %]</option> >+ [%END%] >+ </select> >+ <span class="required">Required</span> >+ </li> >+ >+ <li> >+ <label for="itemtype" class="required">Item type: </label> >+ <select id="itemtype" name="itemtype" required="required"> >+ <option value=""> Choose </option> >+ <option value="*" selected="selected">All</option> >+ [% FOREACH item IN itemtypes %] >+ <option value = "[% item.itemtype | html %]"> [% item.itemtype | html %] >+ [%END%] >+ </select> >+ <span class="required"> Required</span> >+ </li> >+ <li> >+ <label for="maxissueqty" class="required">Current checkouts allowed: </label> >+ <input type="text" inputmode="numeric" pattern="[0-9]*" name="maxissueqty" id="maxissueqty" size="10" value="50" class="required" required="required" /> >+ <span class="required">Required</span> >+ </li> >+ >+ <li> >+ <label for="issuelength" class="required">Loan period: </label> >+ <input type="text" inputmode="numeric" pattern="[0-9]*" name="issuelength" id="issuelength" size="10" value="14" class="required" required="required" /> >+ <span class="required">Required</span> >+ </li> >+ <li> >+ <label for="lengthunit" class="required">Units: </label> >+ <select name="lengthunit" id="lengthunit" required="required"> >+ <option value=""> Choose </option> >+ [% SET units = 'days' %] >+ [% IF category %] >+ [% SET default_privacy = category.default_privacy %] >+ [% END %] >+ >+ [% SWITCH units %] >+ [% CASE 'days' %] >+ <option value="days" selected="selected">Days</option> >+ <option value="hours">Hours</option> >+ [% CASE 'hours' %] >+ <option value="days">Days</option> >+ <option value="hours" selected="selected">Hours</option> >+ [% END %] >+ </select> >+ <span class="required">Required</span> >+ </li> >+ <li> >+ <label for="renewalsallowed" class="required">Renewals allowed: </label> >+ <input type="text" inputmode="numeric" pattern="[0-9]*" name="renewalsallowed" id="renewalsallowed" size="10" value="10" class="required" required="required" /> >+ <span class="required">Required</span> >+ </li> >+ >+ <li> >+ <label for="renewalperiod" class="required">Renewals period: </label> >+ <input type="text" inputmode="numeric" pattern="[0-9]*" name="renewalperiod" id="renewalperiod" size="10" value="14" class="required" required="required" /> >+ <span class="required">Required</span> >+ </li> >+ >+ <li> >+ <label for="reservesallowed">Holds allowed (total): </label> >+ <input type="text" inputmode="numeric" pattern="[0-9]*" name="reservesallowed" id="reservesallowed" size="10" value="10" /> >+ </li> >+ >+ <li> >+ <label for="holds_per_day">Holds allowed (daily): </label> >+ <input type="text" inputmode="numeric" pattern="[0-9]*" name="holds_per_day" id="holds_per_day" size="10" value="10" /> >+ </li> >+ >+ <li> >+ <label for="holds_per_record">Holds per record (count): </label> >+ <input type="text" inputmode="numeric" pattern="[0-9]*" name="holds_per_record" id="holds_per_record" size="10" value="1" /> >+ </li> >+ >+ <li> >+ <label for="onshelfholds">On shelf holds allowed: </label> >+ <select name="onshelfholds" id="onshelfholds" required="required"> >+ <option value="">Choose</option> >+ <option value="1" selected="selected">Yes</option> >+ <option value="0">If any unavailable</option> >+ <option value="2">If all unavailable</option> >+ </select> >+ </li> >+ </ol> >+ <p> >+ To create circulation rule, go to: >+ <span class="breadcrumbs">Administration › Circulation and fine rules </span> >+ </p> >+>>>>>>> Bug 31736: Editing 'All' to 'All libraries' > > <li> > <label for="holds_per_record">Holds per record (count): </label> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt >index 6c379270bd..1d14f4db8f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt >@@ -107,7 +107,7 @@ > <li> > <label>Transaction library</label> > <select name="branch" id="branch"> >- <option value="ALL">All</option> >+ <option value="ALL">All libraries/branches</option> > [% FOREACH branchloo IN branchloop %] > [% IF ( branchloo.selected ) %] > <option value="[% branchloo.branchcode | html %]" selected="selected">[% branchloo.branchname | html %]</option> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt >index 02b37fcc95..ca7d85a19b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt >@@ -143,7 +143,7 @@ > <li > ><label for="branchfilter">Library: </label > ><select name="branchfilter" id="branchfilter"> >- <option value="">All</option> >+ <option value="">All libraries/branches</option> > [% PROCESS options_for_libraries libraries => Branches.all() %] > </select></li > > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt >index ac46cb3e47..6ab3a1ee49 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt >@@ -46,7 +46,7 @@ > <li > ><label for="branch">Library:</label> > <select id="branch" name="branch"> >- <option value="">All</option> >+ <option value="">All libraries/branches</option> > [% PROCESS options_for_libraries libraries => Branches.all( selected => branch ) %] > </select> > </li> >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31736
:
153301
|
153302
|
162545
|
163817
|
163859
|
163860
|
163861
|
163862
|
163863
|
163864
|
163865
|
163866
|
163867
|
163868
|
163869
|
163870
|
163871
|
169498
|
170072
|
170281
|
170282
|
170283
|
170284
|
170285
|
170286
|
170287
|
170288
|
170289
|
170290
|
170291
|
170292
|
170293
| 179845 |
179846
|
179847
|
179848
|
179849
|
179850
|
179851
|
179852
|
179853
|
179854
|
179855
|
179856
|
179857