Bugzilla – Attachment 179903 Details for
Bug 39484
Can't play audio alerts on SCO from an external source
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39484: Fix external sounds in self checkout module
Bug-39484-Fix-external-sounds-in-self-checkout-mod.patch (text/plain), 1.55 KB, created by
Lucas Gass (lukeg)
on 2025-03-30 07:17:46 UTC
(
hide
)
Description:
Bug 39484: Fix external sounds in self checkout module
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-03-30 07:17:46 UTC
Size:
1.55 KB
patch
obsolete
>From 1708a09fd2c744d71756605a4ba57fe9117519dc Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Sun, 30 Mar 2025 07:11:36 +0000 >Subject: [PATCH] Bug 39484: Fix external sounds in self checkout module > >To test: >1. Enable AudioAlerts >2. Set something up in the SCO to play a sound from an external source. ( I used #sco_main as my selector ) >3. Go to SCO and try to trigger the sound, nothing plays. >4. APPLY PATCH >5. Try steps 2 and 3 again, this time you should hear the sound from an external source. >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >index 15f863e1228..96b52a2e478 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >@@ -437,8 +437,8 @@ > function playSound( sound ) { > if (!(sound.indexOf("http://") === 0 || sound.indexOf("https://") === 0)) { > sound = '[% interface | html %]' + '/bootstrap/sound/' + sound; >- document.getElementById("audio-alert").innerHTML = '<audio src="' + sound + '" autoplay="autoplay" autobuffer="autobuffer"></audio>'; > } >+ document.getElementById("audio-alert").innerHTML = '<audio src="' + sound + '" autoplay="autoplay" autobuffer="autobuffer"></audio>'; > } > [% END %] > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39484
:
179902
|
179903
|
179942