Bugzilla – Attachment 179967 Details for
Bug 37211
All notes in the patron account transactions table should be editable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37211: Update permission name to edit_accountline_notes
Bug-37211-Update-permission-name-to-editaccountlin.patch (text/plain), 4.19 KB, created by
Lucas Gass (lukeg)
on 2025-03-31 09:58:44 UTC
(
hide
)
Description:
Bug 37211: Update permission name to edit_accountline_notes
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-03-31 09:58:44 UTC
Size:
4.19 KB
patch
obsolete
>From 0ec8510ab0df0b3b3f0939be4f14f23eb14cdcc9 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 31 Mar 2025 09:58:15 +0000 >Subject: [PATCH] Bug 37211: Update permission name to edit_accountline_notes > >--- > installer/data/mysql/atomicupdate/bug_37211.pl | 6 +++--- > installer/data/mysql/mandatory/userpermissions.sql | 2 +- > koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc | 2 +- > .../intranet-tmpl/prog/en/modules/members/boraccount.tt | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_37211.pl b/installer/data/mysql/atomicupdate/bug_37211.pl >index d011adce27b..5a75a4b845c 100755 >--- a/installer/data/mysql/atomicupdate/bug_37211.pl >+++ b/installer/data/mysql/atomicupdate/bug_37211.pl >@@ -3,7 +3,7 @@ use Koha::Installer::Output qw(say_warning say_failure say_success say_info); > > return { > bug_number => "37211", >- description => "Add permission updatecharges:edit_notes", >+ description => "Add permission updatecharges:edit_accountline_notes", > up => sub { > my ($args) = @_; > my ( $dbh, $out ) = @$args{qw(dbh out)}; >@@ -12,12 +12,12 @@ return { > $dbh->do( > q{ > INSERT IGNORE INTO permissions (module_bit, code, description) >- VALUES (10, 'edit_notes', 'Edit accountline notes') >+ VALUES (10, 'edit_accountline_notes', 'Edit accountline notes') > } > ); > > # permissions >- say_success( $out, "Added new permission 'updatecharges:edit_notes'" ); >+ say_success( $out, "Added new permission 'updatecharges:edit_accountline_notes'" ); > > }, > }; >diff --git a/installer/data/mysql/mandatory/userpermissions.sql b/installer/data/mysql/mandatory/userpermissions.sql >index ac6c0b299bf..d5121c91fd2 100644 >--- a/installer/data/mysql/mandatory/userpermissions.sql >+++ b/installer/data/mysql/mandatory/userpermissions.sql >@@ -71,7 +71,7 @@ INSERT INTO permissions (module_bit, code, description) VALUES > (10, 'manual_credit', 'Add manual credits to a patron account'), > (10, 'manual_invoice', 'Add manual invoices to a patron account'), > (10, 'remaining_permissions', 'Remaining permissions for managing fines and fees'), >- (10, 'edit_notes', 'Edit accountline notes'), >+ (10, 'edit_accountline_notes', 'Edit accountline notes'), > (11, 'currencies_manage', 'Manage currencies and exchange rates'), > (11, 'vendors_manage', 'Manage vendors'), > (11, 'contracts_manage', 'Manage contracts'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >index 812260bbefc..a0e17a2d418 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >@@ -308,7 +308,7 @@ > [%- CASE 'suggestions_create' -%] > <span class="sub_permission suggestions_create_subpermission"> Create purchase suggestions </span> > <span class="permissioncode">([% name | html %])</span> >- [%- CASE 'edit_notes' -%] >+ [%- CASE 'edit_accountline_notes' -%] > <span class="sub_permission edit_notes_subpermission"> Edit accountline notes </span> > <span class="permissioncode">([% name | html %])</span> > [%- CASE 'suggestions_manage' -%] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >index 5646245ca29..c1253fd6ebc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >@@ -135,7 +135,7 @@ > <td>[% IF account.itemnumber %][% Branches.GetName( account.item.homebranch ) | html %][% END %]</td> > <td> > [% account.note | html_line_break %] >- [% IF CAN_user_updatecharges_edit_notes %] >+ [% IF CAN_user_updatecharges_edit_accountline_notes %] > <button > type="button" > class="btn btn-default btn-xs edit-action" >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37211
:
168211
|
168212
|
170002
|
170003
|
170218
|
170219
|
177244
|
177245
|
177248
|
177249
|
177250
|
177251
|
177252
|
177261
|
179178
|
179179
|
179180
|
179181
|
179182
|
179963
| 179967 |
179972
|
179977
|
180923