Bugzilla – Attachment 180078 Details for
Bug 39485
"Wide character in print" when exporting from staff interface and OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39485: Fix wide character in print-warn in opac-export
Bug-39485-Fix-wide-character-in-print-warn-in-opac.patch (text/plain), 1.88 KB, created by
Magnus Enger
on 2025-03-31 15:54:18 UTC
(
hide
)
Description:
Bug 39485: Fix wide character in print-warn in opac-export
Filename:
MIME Type:
Creator:
Magnus Enger
Created:
2025-03-31 15:54:18 UTC
Size:
1.88 KB
patch
obsolete
>From 47e7a3b2d99c9e70a5be13e236231579a40f180b Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 31 Mar 2025 08:28:09 +0000 >Subject: [PATCH] Bug 39485: Fix wide character in print-warn in opac-export > >Similar change in intranet counterpart: catalogue/export. > >Test plan: >Verify no warning anymore when using ris or isbd when record >contains specific Unicode character(s). > >Signed-off-by: Magnus Enger <magnus@libriotech.no> >I could not trigger "Wide character" for RIS in the OPAC, but for >ISBD I can see it removes that warning. >--- > catalogue/export.pl | 2 +- > opac/opac-export.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/catalogue/export.pl b/catalogue/export.pl >index cd81ec3b53..a7c77c62f1 100755 >--- a/catalogue/export.pl >+++ b/catalogue/export.pl >@@ -70,7 +70,7 @@ if ( $op eq "export" ) { > ( $error, $marc ) = marc2marc( $marc, 'marcstd', C4::Context->preference('marcflavour') ); > $format = "marcstd"; > } >- if ( $format =~ /utf8/ or $format =~ /marcstd/ ) { >+ if ( $format ne 'marc8' ) { > binmode STDOUT, ':encoding(UTF-8)'; > } > print $query->header( >diff --git a/opac/opac-export.pl b/opac/opac-export.pl >index 3cb829b453..8a2622a36b 100755 >--- a/opac/opac-export.pl >+++ b/opac/opac-export.pl >@@ -162,6 +162,7 @@ if ($error) { > print $query->escapeHTML("$error"); > print $query->end_html(); > } else { >+ binmode STDOUT, ':encoding(UTF-8)' if $format ne 'marc8'; > if ( $format eq 'marc8' ) { > print $query->header( > -type => 'application/marc', >@@ -181,7 +182,6 @@ if ($error) { > -attachment => "$file_pre$file_id.$format" > ); > } else { >- binmode STDOUT, ':encoding(UTF-8)'; > print $query->header( > -type => 'application/octet-stream', > -charset => 'utf-8', >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39485
:
179914
|
180078
|
181236