Bugzilla – Attachment 180238 Details for
Bug 39368
Warnings from t::lib::Mocks::Zebra because of statement after exec
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39368: Remove warnings from t::lib::Mocks::Zebra
Bug-39368-Remove-warnings-from-tlibMocksZebra.patch (text/plain), 2.18 KB, created by
Martin Renvoize (ashimema)
on 2025-04-02 07:29:28 UTC
(
hide
)
Description:
Bug 39368: Remove warnings from t::lib::Mocks::Zebra
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-04-02 07:29:28 UTC
Size:
2.18 KB
patch
obsolete
>From f40333f229c31565eb02bedf601dd5fd373cb9ef Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 18 Mar 2025 16:20:28 +0100 >Subject: [PATCH] Bug 39368: Remove warnings from t::lib::Mocks::Zebra > >because of statement after exec we get: > # Previous test 1217 'POD coverage for t/lib/Mocks/Logger.pm' > # Statement unlikely to be reached at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. > # at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. > # require t/lib/Mocks/Zebra.pm called at (eval 4894) line 1 > # eval ' require t::lib::Mocks::Zebra ' called at /usr/share/perl5/Pod/Coverage.pm line 308 > # Pod::Coverage::_get_syms(Pod::Coverage=HASH(0x569d3a0bbf50), "t::lib::Mocks::Zebra") called at /usr/share/perl5/Pod/Coverage.pm line 152 > # Pod::Coverage::coverage(Pod::Coverage=HASH(0x569d3a0bbf50)) called at /usr/share/perl5/Pod/Coverage.pm line 209 > # Pod::Coverage::naked(Pod::Coverage=HASH(0x569d3a0bbf50)) called at xt/author/pod_coverage.t line 40 > # main::check_pod_coverage("t/lib/Mocks/Zebra.pm") called at xt/author/pod_coverage.t line 30 > >Test plan: >Run `prove xt/author/pod_coverage.t` and confirm that the tests pass >with this patch applied. >Also confirm that t/db_dependent/www/search_utf8.t still passes > >Note that xt/author/pod_coverage.t is coming from bug 39367. > >Signed-off-by: Magnus Enger <magnus@libriotech.no> >Tested on top of bug 39367. Patch makes the mentioned tests pass. >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > t/lib/Mocks/Zebra.pm | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/t/lib/Mocks/Zebra.pm b/t/lib/Mocks/Zebra.pm >index b5e307cb18e..1d61c029280 100644 >--- a/t/lib/Mocks/Zebra.pm >+++ b/t/lib/Mocks/Zebra.pm >@@ -82,7 +82,6 @@ sub launch_zebra { > my $zebra_pid = fork(); > if ( $zebra_pid == 0 ) { > exec("zebrasrv -f $koha_conf -v none,request -l $datadir/zebra.log"); >- exit; > } > sleep(1); > $self->{zebra_pid} = $zebra_pid; >@@ -97,7 +96,6 @@ sub launch_indexer { > > if ( $indexer_pid == 0 ) { > exec("$rebuild_zebra -daemon -sleep 5"); >- exit; > } > sleep(1); > $self->{indexer_pid} = $indexer_pid; >-- >2.49.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39368
:
179454
|
180086
| 180238