Bugzilla – Attachment 180275 Details for
Bug 35434
Non-superlibrarians should not place holds in other libraries when IndependentBranches is enabled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35434: (follow-up) tidy code
Bug-35434-follow-up-tidy-code.patch (text/plain), 1.37 KB, created by
Eric Bégin
on 2025-04-02 09:47:48 UTC
(
hide
)
Description:
Bug 35434: (follow-up) tidy code
Filename:
MIME Type:
Creator:
Eric Bégin
Created:
2025-04-02 09:47:48 UTC
Size:
1.37 KB
patch
obsolete
>From e83585ffa75de38466e336416227ac4b15adb172 Mon Sep 17 00:00:00 2001 >From: Hammat Wele <hammat.wele@inlibro.com> >Date: Wed, 5 Mar 2025 17:27:28 +0000 >Subject: [PATCH] Bug 35434: (follow-up) tidy code >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Eric Bégin <eric.begin@inlibro.com> >--- > t/db_dependent/Koha/Item.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t >index b9d83e9ed9..609547826e 100755 >--- a/t/db_dependent/Koha/Item.t >+++ b/t/db_dependent/Koha/Item.t >@@ -564,7 +564,7 @@ subtest 'pickup_locations() tests' => sub { > > plan tests => 70; > >- t::lib::Mocks::mock_preference('canreservefromotherbranches', 1); >+ t::lib::Mocks::mock_preference( 'canreservefromotherbranches', 1 ); > $schema->storage->txn_begin; > > my $dbh = C4::Context->dbh; >@@ -903,7 +903,7 @@ subtest 'pickup_locations() tests' => sub { > grep { $pickup_location->branchcode eq $_ } @branchcodes > } $item4->pickup_locations( { patron => $patron5 } )->as_list; > ok( >- scalar(@pickup_locations) == 1 && @pickup_locations[0] eq $library4->branchcode, >+ scalar(@pickup_locations) == 1 && $pickup_locations[0] eq $library4->branchcode, > 'There should be only one branch in the pickup locations, the connected branch' > ); > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35434
:
159346
|
161509
|
166648
|
169917
|
169918
|
169919
|
176045
|
176046
|
176047
|
178296
|
178297
|
178298
|
178999
|
180275
|
182566
|
182567
|
182568
|
182569