Bugzilla – Attachment 180525 Details for
Bug 39544
New / New record generates warnings in log
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39544: New > New record generates warnings in log
Bug-39544-New--New-record-generates-warnings-in-lo.patch (text/plain), 1.41 KB, created by
Magnus Enger
on 2025-04-03 13:28:20 UTC
(
hide
)
Description:
Bug 39544: New > New record generates warnings in log
Filename:
MIME Type:
Creator:
Magnus Enger
Created:
2025-04-03 13:28:20 UTC
Size:
1.41 KB
patch
obsolete
>From 8c4b63ec8caa4903a0da4a69dd57f8cfd72ba07a Mon Sep 17 00:00:00 2001 >From: Janusz Kaczmarek <januszop@gmail.com> >Date: Thu, 3 Apr 2025 12:51:35 +0000 >Subject: [PATCH] Bug 39544: New > New record generates warnings in log > >When creating a new record starting from Normal records view, by using >New > New record warnings in the log will be generated like: > >[2025/04/03 12:45:33] [WARN] Use of uninitialized value $frameworkcode >in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 513. > >Test plan: >========== >1. In staff interface, open any record in Normal view. >2. From upper menu chose New > New record. >3. Check the plack-intranet-error.log file, you should see fresh > warnings with "Use of uninitialized value $frameworkcode". >4. Apply the patch ; restart_all. >5. Repeat p. 1.-3. No new warnings. > >Signed-off-by: Magnus Enger <magnus@libriotech.no> >--- > cataloguing/addbiblio.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl >index b4c3f677c1..58f555d6de 100755 >--- a/cataloguing/addbiblio.pl >+++ b/cataloguing/addbiblio.pl >@@ -509,6 +509,7 @@ my $fa_duedatespec = $input->param('duedatespec'); > $op = $input->param('op') // q{}; > $frameworkcode = &GetFrameworkCode($biblionumber) > if ( $biblionumber and not( defined $frameworkcode ) and $op ne 'cud-addbiblio' ); >+$frameworkcode //= ''; > > my $userflags = > $frameworkcode eq 'FA' >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39544
:
180504
|
180525
|
180528
|
180566