Bugzilla – Attachment 180530 Details for
Bug 39258
Remove extra delete button in report preview modal
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39258: Remove extra nonfunctional Delete button from report preview modal
Bug-39258-Remove-extra-nonfunctional-Delete-button.patch (text/plain), 3.29 KB, created by
Emily Lamancusa (emlam)
on 2025-04-03 13:43:04 UTC
(
hide
)
Description:
Bug 39258: Remove extra nonfunctional Delete button from report preview modal
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2025-04-03 13:43:04 UTC
Size:
3.29 KB
patch
obsolete
>From 7810619edce03adb54a592d1e0b38d2570772adf Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry <andrew@bywatersolutions.com> >Date: Thu, 20 Mar 2025 19:22:04 +0000 >Subject: [PATCH] Bug 39258: Remove extra nonfunctional Delete button from > report preview modal > >To test: >1 - save a report >2 - click Preview SQL for that report from the Saved Reports page >3 - see there are two delete buttons >4 - apply patch, reload page >5 - now there is one delete button >6 - confirm that delete button gives a confirmation message and then deletes the report > >7 - Install a second language for the intranet >8 - switch to that language and confirm you have just 1 delete button, it is translated, and it works > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >--- > .../prog/en/modules/reports/guided_reports_start.tt | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 55afc39ff05..b47ce181b2e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -2607,8 +2607,7 @@ > <a id="preview-modal-editreport" class="btn btn-default" href="/cgi-bin/koha/reports/guided_reports.pl?id=' + reportid + '&op=edit_form"><i class="fa-solid fa-pencil" aria-hidden="true"></i> ' + _("Edit") + '</a>\ > <a id="preview-modal-duplicate" class="btn btn-default" href="/cgi-bin/koha/reports/guided_reports.pl?op=duplicate&id=' + reportid + '"><i class="fa fa-copy" aria-hidden="true"></i> ' + _("Duplicate") + '</a>\ > <a id="preview-modal-duplicate" class="btn btn-default" href="/cgi-bin/koha/tools/scheduler.pl?id=' + reportid + '"><i class="fa-solid fa-clock" aria-hidden="true"></i> ' + _("Schedule") + '</a>\ >- <a class="btn btn-default submit-form-link" href="#" data-id="' + reportid + '" data-action="guided_reports.pl" data-method="post" data-op="cud-delete" data-confirmation-msg="' + _("Are you sure you want to delete this report?") + '"><i class="fa fa-trash-can" aria-hidden="true"></i> Delete</a>\ >- <a id="preview-modal-delete"href="#" class="btn btn-default" title="Delete this saved report"><i class="fa fa-trash-can aria-hidden="true""></i> ' + _("Delete") + '</a>\ >+ <a class="btn btn-default submit-form-link" href="#" data-id="' + reportid + '" data-action="guided_reports.pl" data-method="post" data-op="cud-delete" data-confirmation-msg="' + _("Are you sure you want to delete this report?") + '"><i class="fa fa-trash-can" aria-hidden="true"></i>' + _("Delete") + '</a>\ > <a id="preview-modal-runreport" class="btn btn-default" href="/cgi-bin/koha/reports/guided_reports.pl?id=' + reportid + '&op=run"><i class="fa fa-play" aria-hidden="true"></i> ' + _("Run report") + '</a>\ > <a href="#" id="preview-sql-modal-cancel" data-bs-dismiss="modal" class="btn btn-default"><i class="fa fa-times" aria-hidden="true"></i> ' + _("Close") + '</a>\ > </div>\ >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39258
:
179003
|
179006
|
179499
|
179565
|
179901
| 180530