Bugzilla – Attachment 180610 Details for
Bug 38009
Add a generate next button in serials receive page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38009: Add a generate next button in serials receive page
Bug-38009-Add-a-generate-next-button-in-serials-re.patch (text/plain), 4.22 KB, created by
Wainui Witika-Park
on 2025-04-04 00:46:54 UTC
(
hide
)
Description:
Bug 38009: Add a generate next button in serials receive page
Filename:
MIME Type:
Creator:
Wainui Witika-Park
Created:
2025-04-04 00:46:54 UTC
Size:
4.22 KB
patch
obsolete
>From 92c89738df01c4f6bdf7f3f8eda52b4106e386db Mon Sep 17 00:00:00 2001 >From: wainuiwitikapark <wainuiwitikapark@catalyst.net.nz> >Date: Fri, 15 Nov 2024 00:57:43 +0000 >Subject: [PATCH] Bug 38009: Add a generate next button in serials receive page > >Adds a generate next button to the serials receive page (serials-edit.pl) that works similar to the button on the serials collection page. > >To test: > >1. Go to Staff Client > Serials >2. Find an existing subscription or create a new one >3. Go to the Serials collection page for your serial e.g. /cgi-bin/koha/serials/serials-collection.pl?subscriptionid=1 >4. Click on the "Generate next" button and notice that the table adds > another row >5. Click on the "Receive" button at the top of the page >6. Notice that the page also shows the issues like the rows in the > previous page >7. Apply patch >8. Repeat steps 1-5 >9. Notice that the page also has a "Generate next" button at the top >10. Check that the button generates a new issue row on the page > >Sponsored-by: Pymble Ladies' College >Signed-off-by: esther <esther@bywatersolutions.com> >--- > .../prog/en/includes/modals/generate_next.inc | 1 + > .../intranet-tmpl/prog/en/modules/serials/serials-edit.tt | 5 +++++ > serials/serials-collection.pl | 8 +++++++- > 3 files changed, 13 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/generate_next.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/generate_next.inc >index 8d4594a76de..5895c417df1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/generate_next.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/generate_next.inc >@@ -11,6 +11,7 @@ > <legend>Do you really want to generate next serial?</legend> > <input type="hidden" name="op" value="cud-gennext" /> > <input type="hidden" name="subscriptionid" value="[% subscriptionidlist || subscriptionid | html %]" /> >+ <input type="hidden" name="referrer" value="[% referrer %]" /> > </fieldset> > </div> > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >index 40d5f4cfaf1..b4b63c3d304 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >@@ -131,6 +131,11 @@ > <main> > [% INCLUDE 'messages.inc' %] > >+ <div id="toolbar" class="btn-toolbar"> >+ <div class="btn-group"><input type="button" value="Generate next" href="#generate_next" class="btn btn-default btn-sm" data-bs-toggle="modal" /></div> >+ [% INCLUDE 'modals/generate_next.inc' referrer="serials-edit" %] >+ </div> >+ > <h1 > >Serial edition <em>[% bibliotitle | html %]</em> [% IF location %]([% AuthorisedValues.GetByCode('LOC', location) | html %])[% END %] > [% IF ( callnumber ) %]callnumber: [% callnumber | html %][% END %]</h1 >diff --git a/serials/serials-collection.pl b/serials/serials-collection.pl >index eccb80cbf5f..b3eb1c70013 100755 >--- a/serials/serials-collection.pl >+++ b/serials/serials-collection.pl >@@ -49,6 +49,7 @@ my $biblionumber = $query->param('biblionumber'); > my @subscriptionid = $query->multi_param('subscriptionid'); > my $skip_issues = $query->param('skip_issues') || 0; > my $count_forward = $skip_issues + 1; >+my $referrer = $query->param('referrer'); > > @subscriptionid = uniq @subscriptionid; > @subscriptionid = sort @subscriptionid; >@@ -111,7 +112,12 @@ if ( $op eq 'cud-gennext' && @subscriptionid ) { > last if $nbissues == 1; > last if HasSubscriptionExpired($subscriptionid) > 0; > } >- print $query->redirect( '/cgi-bin/koha/serials/serials-collection.pl?subscriptionid=' . $subscriptionid ); >+ if ($referrer eq "serials-edit") { >+ print $query->redirect('/cgi-bin/koha/serials/serials-edit.pl?subscriptionid='.$subscriptionid.'&serstatus=1,3'); >+ } >+ else { >+ print $query->redirect( '/cgi-bin/koha/serials/serials-collection.pl?subscriptionid=' . $subscriptionid ); >+ } > exit; > } > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38009
:
174539
|
174647
|
176038
|
176039
|
180610
|
180944