Bugzilla – Attachment 180621 Details for
Bug 37451
Restrictions due to discharge should not be able to be removed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37451: Remove the ability to delete a restriction due to discharge
Bug-37451-Remove-the-ability-to-delete-a-restricti.patch (text/plain), 3.22 KB, created by
Baptiste Wojtkowski (bwoj)
on 2025-04-04 09:38:48 UTC
(
hide
)
Description:
Bug 37451: Remove the ability to delete a restriction due to discharge
Filename:
MIME Type:
Creator:
Baptiste Wojtkowski (bwoj)
Created:
2025-04-04 09:38:48 UTC
Size:
3.22 KB
patch
obsolete
>From 59d59fb7952a07423ad6b212df00057610a55186 Mon Sep 17 00:00:00 2001 >From: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> >Date: Wed, 24 Jul 2024 15:52:27 +0200 >Subject: [PATCH] Bug 37451: Remove the ability to delete a restriction due to > discharge > >With the new possibility to remove a discharge, it becomes possible to remove the suspension associated to the discharge without removing the discharge. This can lead to a lot of undesired behaviors when the user asks for another discharge or get suspended for another reason. > >Suspension due to discharge should therefore be definitive. > >TEST PLAN: >1 - Go to patron -> pick a patron -> go to discharges >2 - Generate a discharge for the patron >3 - Go to check out -> restrictions >4 - There should be a restriction with type discharge that can be > deleted >5 - Apply patch and update db >6 - There still should be a restriction but the button has been replaced > by an infobox > >Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> >Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> >--- > .../prog/en/includes/patron-restrictions-tab.inc | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc >index 1cca1bad..df2a1e55 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc >@@ -22,6 +22,7 @@ > <tr [% IF restriction.is_expired %]class="expired"[% END %]> > <td> [% PROCESS restriction_type_description restriction_type=restriction.type %] </td> > <td> >+ [% restriction.type.code | html %] > [% IF restriction.comment.search('OVERDUES_PROCESS') %] > <span>Restriction added by overdues process [% restriction.comment.remove('OVERDUES_PROCESS ') | $raw %]</span> > [% ELSE %] >@@ -39,6 +40,7 @@ > <td>[% restriction.created | $KohaDates %]</td> > [% IF CAN_user_borrowers_edit_borrowers && CAN_user_circulate_manage_restrictions %] > <td> >+ [% IF restriction.type.code != "DISCHARGE" %] > <form method="post" action="/cgi-bin/koha/members/mod_debarment.pl"> > [% INCLUDE 'csrf-token.inc' %] > <input type="hidden" name="op" value="cud-del" /> >@@ -46,7 +48,11 @@ > <input type="hidden" name="borrower_debarment_id" value="[% restriction.borrower_debarment_id | uri %]" /> > <button type="submit" class="remove_restriction btn btn-default btn-xs"><i class="fa fa-trash-can"></i> Remove</button> > </form> >+ [% ELSE %] >+ <i title="Restrictions due to discharges cannot be cancelled" aria-hidden=true data-placement="right" class="fa fa-info-circle"></i> >+ [% END %] > </td> >+ > [% END %] > </tr> > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37451
:
169491
|
172020
|
176455
|
176468
|
179392
|
179393
|
179394
| 180621