Bugzilla – Attachment 180629 Details for
Bug 29074
DefaultHoldExpirationdatePeriod blank value interpreted as zero
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29074: Prevent undef warning when DefaultHoldExpirationdate is read
0002-Bug-29074-Prevent-undef-warning-when-DefaultHoldExpi.patch (text/plain), 1.32 KB, created by
Emmi Takkinen
on 2025-04-04 11:41:41 UTC
(
hide
)
Description:
Bug 29074: Prevent undef warning when DefaultHoldExpirationdate is read
Filename:
MIME Type:
Creator:
Emmi Takkinen
Created:
2025-04-04 11:41:41 UTC
Size:
1.32 KB
patch
obsolete
>From 075c8a7c0d70a15e4ebe464c1152270b4ac4a069 Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Fri, 13 Oct 2023 14:30:36 +0300 >Subject: [PATCH 2/3] Bug 29074: Prevent undef warning when > DefaultHoldExpirationdate is read > >Test plan: >Repeat test plan from first patch. >Also prove t/db_dependent/Hold.t. > >Sponsored-by: Koha-Suomi Oy >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > Koha/Hold.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/Koha/Hold.pm b/Koha/Hold.pm >index 9be57da4d9..2c9d64fa56 100644 >--- a/Koha/Hold.pm >+++ b/Koha/Hold.pm >@@ -949,6 +949,7 @@ sub store { > } > > if ( C4::Context->preference('DefaultHoldExpirationdate') >+ && defined C4::Context->preference('DefaultHoldExpirationdatePeriod') > && C4::Context->preference('DefaultHoldExpirationdatePeriod') ne '' > && !$self->expirationdate ) > { >@@ -962,6 +963,7 @@ sub store { > if ( > ( > C4::Context->preference('DefaultHoldExpirationdate') >+ && defined C4::Context->preference('DefaultHoldExpirationdatePeriod') > && C4::Context->preference('DefaultHoldExpirationdatePeriod') ne '' > && ( !exists $updated_columns{expirationdate} || $hold_reverted ) > ) >-- >2.34.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29074
:
144572
|
154484
|
154813
|
157068
|
157069
|
157128
|
157129
|
180628
|
180629
|
180630
|
181237
|
181249
|
182180