Bugzilla – Attachment 180641 Details for
Bug 37020
bulkmarcimport gets killed after update to 24.05 when inserting large files
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37020: Don't update Elasticsearch index --test option is set
Bug-37020-Dont-update-Elasticsearch-index---test-o.patch (text/plain), 2.20 KB, created by
David Gustafsson
on 2025-04-04 13:10:10 UTC
(
hide
)
Description:
Bug 37020: Don't update Elasticsearch index --test option is set
Filename:
MIME Type:
Creator:
David Gustafsson
Created:
2025-04-04 13:10:10 UTC
Size:
2.20 KB
patch
obsolete
>From 1c4aa95c6585d31c4222246e299a593e300fb337 Mon Sep 17 00:00:00 2001 >From: David Gustafsson <david.gustafsson@ub.gu.se> >Date: Fri, 4 Apr 2025 15:07:51 +0200 >Subject: [PATCH] Bug 37020: Don't update Elasticsearch index --test option is > set > >--- > misc/migration_tools/bulkmarcimport.pl | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl >index bb7f4a76b13..fbdeb0e9b52 100755 >--- a/misc/migration_tools/bulkmarcimport.pl >+++ b/misc/migration_tools/bulkmarcimport.pl >@@ -325,7 +325,6 @@ my $logger = Koha::Logger->get; > my $schema = Koha::Database->schema; > my $lint = MARC::Lint->new; > >- > while () { > > my $record; >@@ -376,7 +375,6 @@ while () { > SetUTF8Flag($record); > &$localcust($record) if $localcust; > >- > if ( ( $verbose // 1 ) == 1 ) { #no dot for verbose==2 > print "." . ( $record_number % 100 == 0 ? "\n$record_number" : '' ); > } >@@ -596,7 +594,9 @@ while () { > } elsif ($insert) { > my $record_clone = $record->clone(); > C4::Biblio::_strip_item_fields($record_clone); >- eval { ( $record_id, $biblioitemnumber ) = AddBiblio( $record_clone, $framework, $add_biblio_options ) }; >+ eval { >+ ( $record_id, $biblioitemnumber ) = AddBiblio( $record_clone, $framework, $add_biblio_options ); >+ }; > if ($@) { > warn "ERROR: Insert biblio $originalid failed: $@\n"; > printlog( { id => $originalid, op => "insert", status => "ERROR" } ) if ($logfile); >@@ -715,7 +715,7 @@ while () { > $records_exhausted = 1; > } > >- if ( $record_number % $commitnum == 0 || $record_number == $number || $records_exhausted ) { >+ if ( !$test_parameter && $record_number % $commitnum == 0 || $record_number == $number || $records_exhausted ) { > if ($indexer) { > $indexer->update_index( \@search_engine_record_ids, \@search_engine_records ) unless $skip_indexing; > if ( C4::Context->preference('AutoLinkBiblios') ) { >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37020
:
176388
|
176425
|
176653
|
176921
|
180639
|
180640
|
180641
|
180644
|
180645
|
180905
|
180906
|
181463
|
181470
|
181471
|
181472
|
181996
|
181997
|
181998