Bugzilla – Attachment 180673 Details for
Bug 38922
auth_header.origincode and auth_header.linkid never used -- shouldn't it be removed?
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38922: Remove references to auth_header.origincode and auth_heder.linkid from the code
Bug-38922-Remove-references-to-authheaderorigincod.patch (text/plain), 3.09 KB, created by
Janusz Kaczmarek
on 2025-04-04 19:03:56 UTC
(
hide
)
Description:
Bug 38922: Remove references to auth_header.origincode and auth_heder.linkid from the code
Filename:
MIME Type:
Creator:
Janusz Kaczmarek
Created:
2025-04-04 19:03:56 UTC
Size:
3.09 KB
patch
obsolete
>From 182f353437ccb0e018c45236f1e57e901f6c90d8 Mon Sep 17 00:00:00 2001 >From: Janusz Kaczmarek <januszop@gmail.com> >Date: Fri, 4 Apr 2025 16:27:14 +0000 >Subject: [PATCH] Bug 38922: Remove references to auth_header.origincode and > auth_heder.linkid from the code > >--- > C4/AuthoritiesMarc.pm | 5 ----- > Koha/Authority.pm | 2 -- > authorities/authorities.pl | 2 -- > misc/migration_tools/ifla/data/defaults.yml | 1 - > 4 files changed, 10 deletions(-) > >diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm >index 8d0c994ad6..56e8acb21a 100644 >--- a/C4/AuthoritiesMarc.pm >+++ b/C4/AuthoritiesMarc.pm >@@ -271,11 +271,6 @@ sub SearchAuthorities { > > if ( $nbresults > 0 ) { > >- ##Find authid and linkid fields >- ##we may be searching multiple authoritytypes. >- ## FIXME this assumes that all authid and linkid fields are the same for all authority types >- # my ($authidfield,$authidsubfield)=GetAuthMARCFromKohaField($dbh,"auth_header.authid",$authtypecode[0]); >- # my ($linkidfield,$linkidsubfield)=GetAuthMARCFromKohaField($dbh,"auth_header.linkid",$authtypecode[0]); > while ( ( $counter < $nbresults ) && ( $counter < ( $offset + $length ) ) ) { > > ##Here we have to extract MARC record and $authid from ZEBRA AUTHORITIES >diff --git a/Koha/Authority.pm b/Koha/Authority.pm >index 5ebdc9e3a7..b785cc1a0f 100644 >--- a/Koha/Authority.pm >+++ b/Koha/Authority.pm >@@ -302,10 +302,8 @@ sub to_api_mapping { > authtrees => undef, > authtypecode => 'framework_id', > datecreated => 'created_date', >- linkid => undef, > marcxml => undef, > modification_time => 'modified_date', >- origincode => undef, > }; > } > >diff --git a/authorities/authorities.pl b/authorities/authorities.pl >index 3385a260fa..9c39ef7ad1 100755 >--- a/authorities/authorities.pl >+++ b/authorities/authorities.pl >@@ -537,7 +537,6 @@ my $authid = $input->param('authid') =~ s/\D//gr > ; # if authid exists, it's a modif, not a new authority. We remove from authid all non-digit characters just in case the CGI parameter contains weird characters like spaces > my $op = $input->param('op'); > my $myindex = $input->param('index'); >-my $linkid = $input->param('linkid'); > my $authtypecode = $input->param('authtypecode'); > my $breedingid = $input->param('breedingid'); > >@@ -675,7 +674,6 @@ $template->param( > authority_types => $authority_types, > authtypecode => $authtypecode, > authid => $authid, >- linkid => $linkid, > authtypetext => $type ? $type->authtypetext : "", > hide_marc => C4::Context->preference('hide_marc'), > ); >diff --git a/misc/migration_tools/ifla/data/defaults.yml b/misc/migration_tools/ifla/data/defaults.yml >index 4c19cd352b..55df950941 100644 >--- a/misc/migration_tools/ifla/data/defaults.yml >+++ b/misc/migration_tools/ifla/data/defaults.yml >@@ -6,7 +6,6 @@ authsubfield: > isurl: 0 > kohafield: ~ > libopac: '' >- linkid: 0 > mandatory: 0 > repeatable: 1 > seealso: ~ >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38922
:
180671
|
180672
|
180673
|
180674
|
180677
|
180678
|
180679
|
180680