Attachment 18085 Details for Bug 10217 – [PASSED QA] Bug 10217 - Make sure direct links to detail views work when there is no session

[patch] [PASSED QA] Bug 10217 - Make sure direct links to detail views work when there is no session

PASSED-QA-Bug-10217---Make-sure-direct-links-to-de.patch (text/plain), 1.60 KB, created by Katrin Fischer on 2013-05-11 14:35:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2013-05-11 14:35:52 UTC

Size: 1.60 KB

patch

obsolete

>From 70507e1186356f595d8d0553a7ec5838c79f470c Mon Sep 17 00:00:00 2001
>From: Magnus Enger <magnus@enger.priv.no>
>Date: Wed, 8 May 2013 12:03:48 +0200
>Subject: [PATCH] [PASSED QA] Bug 10217 - Make sure direct links to detail
> views work when there is no session
>
>To reproduce:
>- Make sure you do not have a session for the OPAC you will be testing
>  with. Delete the CGISESSID session cookie if you have one.
>- Go directly to a detail view, e.g.:
>  /cgi-bin/koha/opac-detail.pl?biblionumber=1
>- Observe the error "Can't use an undefined value as a HASH
>  reference at /home/magnus/scripts/kohadev/opac/opac-detail.pl line 445."
>
>To test:
>- Apply the patch
>- Reload the page with the error
>- You should now see the detail view of the record, as usual
>
>Thanks to Chris Cormack who suggested the fix for this!
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Tested according to test plan, confirmed patch fixes the problem.
>All tests and QA script pass.
>---
> opac/opac-detail.pl |    5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl
>index bab4ff6..722a401 100755
>--- a/opac/opac-detail.pl
>+++ b/opac/opac-detail.pl
>@@ -442,7 +442,10 @@ if ($hideitems) {
> }
> 
> my $branches = GetBranches();
>-my $branch = C4::Context->userenv->{branch};
>+my $branch = '';
>+if (C4::Context->userenv){
>+    $branch = C4::Context->userenv->{branch};
>+}
> if ( C4::Context->preference('HighlightOwnItemsOnOPAC') ) {
>     if (
>         ( ( C4::Context->preference('HighlightOwnItemsOnOPACWhich') eq 'PatronBranch' ) && $branch )
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 10217: 18017 | 18037 | 18085