Bugzilla – Attachment 180875 Details for
Bug 38685
ILL pages have incomplete breadcrumbs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38685: Only render breadcrumb item if content not empty
Bug-38685-Only-render-breadcrumb-item-if-content-n.patch (text/plain), 1.54 KB, created by
Pedro Amorim
on 2025-04-11 14:33:56 UTC
(
hide
)
Description:
Bug 38685: Only render breadcrumb item if content not empty
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-04-11 14:33:56 UTC
Size:
1.54 KB
patch
obsolete
>From d934b0f610cacfa5f546f061fbb29c043bb6b22a Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Thu, 12 Dec 2024 13:01:23 +0000 >Subject: [PATCH] Bug 38685: Only render breadcrumb item if content not empty > >This ensures the '>' caret is only rendered if there is indeed some >breadcrumb content. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../prog/en/includes/html_helpers.inc | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >index 4bf568b5f70..f2974790a67 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >@@ -552,12 +552,14 @@ > > [%# Used to build individual breadcrumb items in the breadcrumb nav %] > [% BLOCK breadcrumb_item %] >- [% IF ( bc_active ) %] >- <li class="breadcrumb-item active" aria-current="page"> >- <a href="#"> [% content | $raw %] </a> >- </li> >- [% ELSE %] >- <li class="breadcrumb-item"> [% content | $raw %] </li> >+ [% IF content.trim %] >+ [% IF ( bc_active ) %] >+ <li class="breadcrumb-item active" aria-current="page"> >+ <a href="#"> [% content | $raw %] </a> >+ </li> >+ [% ELSE %] >+ <li class="breadcrumb-item"> [% content | $raw %] </li> >+ [% END %] > [% END %] > [% END %] > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38685
:
175397
|
175399
|
175400
|
175401
|
175460
|
175461
|
175462
|
175463
|
176273
|
176274
|
176275
|
176276
|
179787
|
179788
|
179789
|
179790
|
180874
| 180875 |
180876
|
180877